Review tweaks

WordPress · May 29, 2020 · 120daec · 120daec
1 parent f041a88
commit 120daec
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/packages/block-editor/src/components/inserter/block-list.js b/packages/block-editor/src/components/inserter/block-list.js
@@ -48,15 +48,13 @@ export function InserterBlockList( {
 		rootClientId,
 		onInsert
 	);
-	const { rootChildBlocks } = useSelect(
+	const rootChildBlocks = useSelect(
 		( select ) => {
 			const { getBlockName } = select( 'core/block-editor' );
 			const { getChildBlockNames } = select( 'core/blocks' );
 			const rootBlockName = getBlockName( rootClientId );
 
-			return {
-				rootChildBlocks: getChildBlockNames( rootBlockName ),
-			};
+			return getChildBlockNames( rootBlockName );
 		},
 		[ rootClientId ]
 	);

diff --git a/packages/block-editor/src/components/inserter/hooks/use-block-types-state.js b/packages/block-editor/src/components/inserter/hooks/use-block-types-state.js
@@ -56,8 +56,7 @@ const useBlockTypesState = ( rootClientId, onInsert ) => {
 		}
 	}, [] );
 
-	const onSelectItem = ( item ) => {
-		const { name, initialAttributes, innerBlocks } = item;
+	const onSelectItem = ( { name, initialAttributes, innerBlocks } ) => {
 		const insertedBlock = createBlock(
 			name,
 			initialAttributes,

diff --git a/packages/block-editor/src/components/inserter/hooks/use-insertion-point.js b/packages/block-editor/src/components/inserter/hooks/use-insertion-point.js
@@ -14,10 +14,10 @@ import { speak } from '@wordpress/a11y';
 /**
  * @typedef WPInserterConfig
  *
- * @property {string=}   rootClientId        Inserter Root Client ID.
+ * @property {string=} rootClientId        Inserter Root Client ID.
  * @property {string=} clientId            Inserter Client ID.
- * @property {boolean}   isAppender          Whether the inserter is an appender or not.
- * @property {boolean}   selectBlockOnInsert Whether the block should be selected on insert.
+ * @property {boolean} isAppender          Whether the inserter is an appender or not.
+ * @property {boolean} selectBlockOnInsert Whether the block should be selected on insert.
  */
 
 /**
@@ -50,7 +50,7 @@ function useInsertionPoint( {
 			if ( ! destRootClientId && ! clientId && ! isAppender ) {
 				const end = _getBlockSelectionEnd();
 				if ( end ) {
-					destRootClientId = getBlockRootClientId( end ) || undefined;
+					destRootClientId = getBlockRootClientId( end );
 				}
 			}
 			return {