Template Loader: Get rid of _wp_current_template_part_ids globals #22143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…template_part_block, ditch global
|
Size Change: +2.22 kB (0%) Total Size: 824 kB
ℹ️ View Unchanged
|
This reverts commit 427d691.
ockham
changed the title
|
I'll look into failing e2e tests. |
This reverts commit eb3efcb.
|
Fixed tests, and changed a few variable and function names to represent better what they do. No functional changes -- going to merge 🙂 |
6 tasks
6 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Final piece of a refactor that started with #21959 and #21980.
This PR changes:
TheEdit: I reverted this commit since it caused issues outside of FSE.gutenberg_template_loader_filter_block_editor_settingsfilter to infer the current template ID from the$settingsarray it is given as an arg, allowing us to drop the$_wp_current_template_idglobal.create_auto_draft_for_template_part_blockfunction to return a list of template part IDs, and thegutenberg_find_template_postfunction to include that information in its return value, allowing us to drop the$_wp_current_template_part_idsglobal.There's one commit for each change which should make reviewing a bit easier.
How has this been tested?
Verify that Full Site Editing still works as before.
Checklist: