-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP 5.5: merge all PHP changes #23210
Comments
Ella, I can help prepare a patch to bring in the changes related to |
@nosolosw Thanks! |
Found a neat trick to collapse also there file types that's not available in the Github UI: https://github.com/WordPress/gutenberg/compare/release%2F7.5...master?file-filters%5B%5D=.php It's still a huge page that has problems loading though. |
The good news is that I plan to backport:
|
@TimothyBJacobs @spacedmonkey Just to note in this thread, are you aiming at bringing the menu endpoints into core for 5.5, because if so the files in that update these will be handled by one of you in a patch right? (This is just something in my memory but I could be completely wrong) |
Will any of the Gutenberg features utilizing the endpoints be shipping in 5.5? If so, yep that's my plan.
Yeah we have a tracking ticket for it on Core and will make sure they get merged. |
There is a Trac ticket for block types REST API endpoint, but it as well rather depends on whether we integrate it with the codebase. I'll be looking into backporting |
I might ship the block types endpoint regardless, since we're dropping the individual block renderer endpoints there wouldn't otherwise be a way to get those attributes. That being said, I'd be infinitely more comfortable if Gutenberg was using it. |
Is there any documentation around that? |
AFAIK, no documentation but it's just a copy script that happens on npm install (or build) |
I have a PR for menus endpoint and block types |
Hi @TimothyBJacobs ,
It likely that the Navigation page won't make it but the Navigation block does use the endpoints to "create from existing". On the other hand I don't know if the block will be out of experimental by that time. My question was mostly related to @spacedmonkey 's effort above :) |
Ella, I've got clarity about some global styles related things, and we're not shipping them in 5.5, I've crossed out a couple of files we don't need ( I've also audited |
We also need to port this - #22721 |
Do we know when a decision will be made on that? We really need first party usage before including the nav endpoints in Core. |
I added some fields to the Sound about right @TimothyBJacobs ? 😊 |
Yep! See also #23054. |
I think that it (still) doesn't make sense to ship the Navigation block without also shipping either FSE or the Navigation screen. The block isn't very useful inside posts or pages. |
PR: #23321 |
@noisysocks The navigation block shouldn't be included this release. |
@spacedmonkey @TimothyBJacobs If a REST API endpoint will not be used by anything, there's probably no point in adding it to core. On the contrary, maybe it does more damage as we won't be able to change it if it isn't experimental. |
Agreed. The menus route is no longer in the milestone. |
@TimothyBJacobs Is the block types endpoint still something that should be merged? |
I’d prefer to see it being used to bootstrap the editor, I believe @gziolo is looking at that? But I think it is important to land regardless since the individual block renderer endpoints, and their accompanying attribute schemas, have been dropped in 5.5. I’m less worried about block types since it is pretty much a direct output of the block registration RFC which as I understand it has been stabilized. |
There is still some time left to work on integration with the block types endpoint. It’s very solid and follows the RFC fully. If we missed anything we can fix it during the release process. I want us to have at least a proof of concept that validates integration with the block registration on the client. |
We still need to check what was added to |
The enqueue code from |
This is done right? Closing, let me know if we should reopen |
With the WordPress 5.5 beta release around the corner, all PHP changes since Gutenberg v7.5 have to be merged with Core. Since we already want to merge Gutenberg 8.4 into core (updating the JS packages), this needs to be done as soon as possible, before 2020-06-24.
WP_Block
andWP_Block_List
: https://core.trac.wordpress.org/ticket/49926Update default block categories: https://core.trac.wordpress.org/ticket/50278Together with package update.block.json
metadata file: https://core.trac.wordpress.org/ticket/50263It looks like the following files have changed.
I collapsed some directories that contain one feature.
? = Undecided
x = Not for this release
A = Assigned
A
lib/block-directory.php (Block Directory)@tellyworthA lib/blocks.php (Block API) @gziolo @epiqueras
A
lib/class-wp-block-list.php (Block API)@gziolo @epiquerasA lib/class-wp-block-pattern-categories-registry.php (Block Patterns) @youknowriad
A lib/class-wp-block-patterns-registry.php (Block Patterns) @youknowriad
A
lib/class-wp-block.php (Block API)@gziolo @epiquerasA
lib/class-wp-rest-block-directory-controller.php (Block Directory)@tellyworth @TimothyBJacobsA
lib/class-wp-rest-block-types-controller.php (Block API)@spacedmonkey @TimothyBJacobsx
lib/class-wp-rest-customizer-nonces.php (Navigation Screen)A
lib/class-wp-rest-image-editor-controller.php (Image editing)@ajlende @TimothyBJacobs @azaozz @ellatrixx
lib/class-wp-rest-menu-items-controller.php (Navigation Screen)x
lib/class-wp-rest-menu-locations-controller.php (Navigation Screen)x
lib/class-wp-rest-menus-controller.php (Navigation Screen)A
lib/class-wp-rest-plugins-controller.php (Block Directory)@tellyworth @TimothyBJacobsx
lib/class-wp-rest-widget-forms.php (Widget Screen)lib/client-assets.php
A lib/compat.php @gziolo
x
lib/demo-block-template-parts/header.html (FSE)x
lib/demo-block-templates/ (FSE)x
lib/edit-site-export.php (FSE)x
lib/edit-site-page.php (FSE)x
lib/editor-features.php (Global Styles)x
lib/experimental-default-theme.json (FSE)x
lib/experiments-page.php (Internal)x
lib/global-styles.php (Global Styles)x
lib/load.php (Internal)x
lib/navigation-page.php (Navigation Screen)A lib/patterns/ (Block Patterns) @youknowriad
lib/rest-api.phpx
lib/template-loader.php (FSE)x
lib/template-parts.php (FSE)x
lib/templates.php (FSE)x
lib/utils.php (Internal)x
lib/widgets.php (Widget Screen)To know what changed in specific files, I use
git diff release/7.5...master -- lib/compat.php
for example.The text was updated successfully, but these errors were encountered: