-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid rendering fills if empty elements inside #20495
Conversation
Size Change: +154 B (0%) Total Size: 866 kB
ℹ️ View Unchanged
|
I don't really understand where the failing 404 is being triggered. |
@@ -1,56 +0,0 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new implementation, it's hard to unit test these components with snapshots. I removed the tests because these are already covered in e2e tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closes #20480
The diff looks big but in the end, it's just moving things around to avoid rendering the Fills if their content is empty. This ensures that if there are no fills, the slot is empty too.
I tried a CSS fix but it's not that easy.