Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Ungroupable, non-reusable blocks show redundant block settings popover section #20480

Closed
aduth opened this issue Feb 26, 2020 · 1 comment · Fixed by #20495
Closed
Assignees
Labels
[Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Feb 26, 2020

Possible regression of #19344 (cc @youknowriad, @jasmussen )

image

Steps to Reproduce:

  1. Navigate to Posts > Add New
  2. Insert Social Icons block
  3. Click block settings
  4. Observe undesirable blank section between "Duplicate" and "Remove block"

Suspected cause:

This section of the block settings normally contains "Add to Reusable blocks" and "Group" options, which leads me to think that we are not correctly omitting the section when a block is neither reusable nor groupable.

Example for paragraph block:

image

I note that this is a "possible regression of #19344", because I am not able to reproduce this in WordPress 5.4 Beta 3, but I can reproduce it in the latest master.

@aduth aduth added [Type] Bug An existing feature does not function as intended [Package] Block editor /packages/block-editor labels Feb 26, 2020
@gziolo
Copy link
Member

gziolo commented Feb 26, 2020

It might be related to #20233. It has guard clause that checks fills before it renders the wrapper but it might be buggy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants