Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine multiselect. #19121

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Refine multiselect. #19121

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2c5c23
Refine multiselect.
jasmussen Dec 13, 2019
7bb39bc
Refine colors, add dark theme exception.
jasmussen Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/base-styles/_colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ $blue-medium-100: #e5f5fa;
$blue-medium-highlight: #b3e7fe;
$blue-medium-focus: #007cba;

$blue-blueberry: #5f7efd;


// Alert colors.
$alert-yellow: #f0b849;
$alert-red: #d94f4f;
Expand Down
10 changes: 6 additions & 4 deletions packages/block-editor/src/components/block-list/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
.block-editor-block-list__block.is-multi-selected {
// Show selection borders around every non-nested block's actual footprint.
> .block-editor-block-list__block-edit > [data-block] {
box-shadow: 0 0 0 2px #057cba;
box-shadow: 0 0 0 2px $blue-blueberry, 0 0 0 4px $white;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this. Guaranteed to see something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played a bit with a dashed line (white and blue), but it's a bit too busy. Perhaps if the dashed lines could be longer, it would work better (maybe border image). In any case this is looking good.

border-radius: 1px;

// Windows High Contrast mode will show this outline.
Expand All @@ -195,9 +195,11 @@
margin-left: $block-padding;
}

// Hide the native selection marker once we select multiple blocks.
::selection {
background: transparent;
// Provide exceptions for placeholders.
.components-placeholder {
::selection {
background: transparent;
}
}
}
}
Expand Down