adds new edit flow to the video block #15516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
This was referenced May 8, 2019
kjellr
added
[Block] Video
kjellr
reviewed
May 9, 2019
gziolo
added
the
Good First Review
jorgefilipecosta
approved these changes
May 24, 2019
draganescu
force-pushed
the
update/new-edit-flow-video
branch
from
e932929
to
147513f
Compare
|
@jorgefilipecosta I have updated the code as per review and also rebased. Let me know if I understood your comments properly :) |
|
I'm not sure if this is solely related to the Video block because I haven't tested it with others yet, but there's a bug when transforming the Video block to a Media+Text block and then back again to a VIdeo block. The Expected behavior: Icons in the toolbar should remain in the same position for each block.
|
|
@mapk see this comment on the same issue on the embed block. I will treat it in a separate issue. |
afercia
added
the
[Focus] Accessibility (a11y)
|
Related to the "swapping" icon: #16048 |
|
#11952 changed direction so closing this as it became irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #14795
This is a follow up to the image block edit flow update which ports the new flow to all the blocks which have media with an edit state.
How has this been tested?
For now I've only tested locally.
Types of change
New feature (non-breaking change which adds functionality)
Screenshots