Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text change for the block change tooltip #14328

Closed
wants to merge 34 commits into from
Closed

Commits on Mar 12, 2019

  1. Configuration menu
    Copy the full SHA
    3b81591 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. RichText: change value to have separate keys for line and object form…

    …ats (#13948)
    
    * Add objects and lineFormats
    
    * Update RichText
    
    * Fix image toolbar
    
    * Update format placeholder
    
    * lineFormat => lines
    
    * concatPair => mergePair
    
    * Update selectedFormat checks
    
    * Add some extra info to create docs
    
    * Move create docs inline
    
    * Merge lines and objects
    
    * Fix typos
    
    * Add getActiveObject unit tests
    
    * Update docs
    
    * Rebase
    
    * Adjust unstableToDom arguments
    
    * Remove normaliseFormats from list functions
    
    * Update native files
    
    * Update native file
    ellatrix authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    186b672 View commit details
    Browse the repository at this point in the history
  2. RichText: try alternative list shortcuts (to tab) (#14343)

    * RichText: try alternative list shortcuts
    
    * Try tooltips
    
    * Change tooltips to use text
    
    * Add inline comments
    
    * Add e2e test
    
    * Rebase
    ellatrix authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    08da64b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d7a4dfa View commit details
    Browse the repository at this point in the history
  4. Components: update Button readme to add design guidelines (#14194)

    These changes add design documentation. Co-Authored-By: kjellr <[email protected]>
    davewhitley authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    1e541fb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c7d14ca View commit details
    Browse the repository at this point in the history
  6. Document outline: Use links not buttons (#10815)

    * Adjust document outline to use an a tag vs button
    
    * target href links directly to page anchors, remove onClick handler
    
    * update test snapshot
    
    * update snapshot
    
    * better titleNode targeting
    
    * update snapshot
    
    * update snapshot
    
    * Close the table of contents panel when a link is clicked
    
    * add deterministic block id to tests
    
    * remove redundant screen reader text
    
    * Adjust map to avoid mutating original object
    
    * update snapshot
    
    * Update packages/editor/src/components/document-outline/index.js
    
    Co-Authored-By: adamsilverstein <[email protected]>
    
    * Update packages/editor/src/components/document-outline/test/index.js
    
    remove leading _
    
    Co-Authored-By: adamsilverstein <[email protected]>
    
    * Update packages/editor/src/components/document-outline/index.js
    
    Co-Authored-By: adamsilverstein <[email protected]>
    
    * update snapshot
    
    * update snapshots
    
    * update snapshot
    
    * update snapshots
    
    * fix up e2e tests
    
    * Fix snapshots by removing single quotes from outline links
    
    * Update packages/editor/src/components/document-outline/index.js
    
    Co-Authored-By: adamsilverstein <[email protected]>
    
    * change target to href
    
    * rename close -> closeOutline
    
    * update snapshots after property name changes
    
    * rename close/onClose -> onRequestClose for TOC, on
    
    * restore onSelect
    
    * complete renaming
    
    * Block links are only valid for the current session - remove hash after following
    
    * update snapshot
    
    * cleanup; move block id hash removal functionality up to document outline; now includes title
    
    * update snapshot
    
    * use replaceState vs pushState
    
    * use defer and import at top of file
    
    * removeURLHash as helper
    
    * remove passing event in select handler
    
    * improve doc block
    
    * Skip title in outline when title node not found
    
    * remove removeURLHash
    Adam Silverstein authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    a06f931 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cd456f6 View commit details
    Browse the repository at this point in the history
  8. Plugin: Remove replace_editor filter, extend core editor (#13569)

    * Plugin: Remove replace_editor filter, extend core editor
    
    * Plugin: Avoid dynamic dependencies for wp-block-library style
    
    This is handled by core in common blocks style enqueues behavior https://github.com/WordPress/wordpress-develop/blob/e421f26/src/wp-includes/script-loader.php#L2626-L2630
    
    * Testing: Leverage saveDraft for meta boxes save
    aduth authored Mar 13, 2019
    Configuration menu
    Copy the full SHA
    67656bc View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. Configuration menu
    Copy the full SHA
    68ef5e7 View commit details
    Browse the repository at this point in the history
  2. Use <s> for strikethrough, not <del> (#14389)

    * Use <s> for strikethrough, not <del>
    
    * Update e2e test
    ellatrix authored Mar 14, 2019
    Configuration menu
    Copy the full SHA
    13334d7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    589a634 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dc03691 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    244d7ce View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7964f38 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9a93e6a View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2019

  1. Docs: Add anchor link to section in scripts readme (#14439)

    * Add anchor link
    
    * Add anchor link to second reference
    mkaz authored and gziolo committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    176fdaf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d21e382 View commit details
    Browse the repository at this point in the history
  3. Update/e2e tests options (#14129)

    * added an interactive argument to the test-e2e script
    
    * mend
    
    * added a way to bypass certain args from Jest, reverted to normal argument passing using double dash
    
    * simplified the argument cleanup function
    
    * simplified the argument cleanup function
    
    * added a way to bypass certain args from Jest, reverted to normal argument passing using double dash
    
    * simplified the argument cleanup function
    
    * simplified the argument cleanup function
    
    * cleaned up the code by moving the prefixed arguments removal to getcliargs
    draganescu authored and gziolo committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    3cc3c89 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2dad4ef View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    790cb30 View commit details
    Browse the repository at this point in the history
  6. Input Interaction: fix buffer for the triggering of multi-select (#14448

    )
    
    * Input Interaction: fix buffer for the triggering of multi-select
    
    * Add inline comment
    
    * Add e2e test
    ellatrix authored Mar 15, 2019
    Configuration menu
    Copy the full SHA
    3848167 View commit details
    Browse the repository at this point in the history
  7. Fix typos (#14451)

    Soean authored and gziolo committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    6c8486f View commit details
    Browse the repository at this point in the history
  8. Input Interaction: only consider selection at edge if directed toward…

    …s it (#14450)
    
    * Input Interaction: only consider selection at edge if directed towards it
    
    * Add e2e test
    ellatrix authored Mar 15, 2019
    Configuration menu
    Copy the full SHA
    542151d View commit details
    Browse the repository at this point in the history
  9. Components: update CheckboxControl readme (#14153)

    * Initial commit to update CheckboxControl readme
    
    These changes add design documentation.
    
    * Fix tabbing on code example
    davewhitley authored and Tammie Lister committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    7723b06 View commit details
    Browse the repository at this point in the history
  10. Use a left border for hover + selection states (#14145)

    * Add thick borders to the left of blocks when they're hovred + selected.
    
    * Add thick left border to the page title.
    
    * Turn off block toolbar centering for alignwide blocks.
    
    This splits the left border in two, which looks a bit weird.
    
    * Move block breadcrump to the left side, position it on top of the block.
    
    * Clean up the block toolbar's left border.
    
    * Use inset borders on mobile.
    
    * Prevent inset borders from overlapping with full-bleed content.
    
    * Use a gray border instead of a blue one on hover.
    
    * Use a sass variable to define the left block border width
    
    * Fix breadcrumb potision for alignfull blocks.
    
    * Clean up breadcrumb position for left & right-aligned blocks.
    
    * Sync block mover animation up with the hover state.
    
    * Darken focused block borders slightly.
    
    From $light-gray-500 to $light-gray-800.
    
    * Switch to using border instead of outline for block borders.
    
    Also, change the thick left border to a solid color, to prevent weird overlap.
    
    * Make this work better with Windows High Contrast Mode
    
    * Adjust z-index of border + breadcrumb for child blocks.
    
    So that they're not overlapped by the parent block's border + toolbar.
    
    * Remove extra z-index rule from the block border.
    
    Turns out this wasn't needed anyway.
    
    * Remove extra z-index rule from the block border. Minor description cleanup.
    
    * Ensure these styles are compatible with Top Toolbar mode.
    
    * Use the new gray value for the mobile toolbar border.
    
    * Add a matching left border to the post permalink area above the title.
    
    * Improve border position for mobile screens, especially for elements that float left/right.
    
    * Remove a couple unnecessary border updates from 047e1e4.
    
    Turns out these styles can be preserved on all screen sizes with no ill effect.
    
    * Clean up bugs related to the hover + focus states of the classic editor block.
    
    * Classic Block toolbar icon cleanup.
    
    Even out margins, remove white background.
    
    * Reusable Block border cleanup.
    
    * Keeping a light border on the classic block when it's inactive.
    
    * Clean up borders on warning blocks.
    
    * Switch to a solid color border color for the permalink box.
    
    This mirrors the approach we use for block toolbars, and also ensures that we don't layer opacities and make the permalink toolbar darker than intended.
    
    * Update z-index rule name to match the one used in the latest merge.
    
    * Combine full-wide toolbar centering rules.
    
    Previously, these were declared in two separate palces.
    
    * Add a darker hover state for dark themes.
    
    * Remove the left toolbar border on mobile screens.
    
    This fixes some visual bugs with themes like TwentyNineteen, which include margins on either side of the block on mobile.
    kjellr authored Mar 15, 2019
    Configuration menu
    Copy the full SHA
    08bf9e1 View commit details
    Browse the repository at this point in the history
  11. Input Interaction: allow outer vertical edge to be selected (#14453)

    * Input Interaction: allow outer vertical edge to be selected
    
    * Add e2e test
    ellatrix authored Mar 15, 2019
    Configuration menu
    Copy the full SHA
    39bd834 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7779964 View commit details
    Browse the repository at this point in the history
  13. DOM: Limit single tabbable radio input by name (#14128)

    * DOM: Limit single tabbable radio input by name
    
    * DOM: Avoid consolidating unnamed radio inputs
    aduth authored Mar 15, 2019
    Configuration menu
    Copy the full SHA
    1019c17 View commit details
    Browse the repository at this point in the history
  14. Update MenuItemsChoice readme (#14465)

    Add design guidelines and screenshots.
    kjellr authored and Tammie Lister committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    09e72df View commit details
    Browse the repository at this point in the history
  15. Add MenuGroup design documentation (#14466)

    * Update MenuGroup Readme.
    
    Add design guidelines and screenshots.
    
    * Adjust introduction to be more concise.
    kjellr authored and Tammie Lister committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    6f7fc09 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2019

  1. Configuration menu
    Copy the full SHA
    82df754 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'update/tooltip-change-block' of github.com:WordPress/gu…

    …tenberg into update/tooltip-change-block
    mapk committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    f3c0ed2 View commit details
    Browse the repository at this point in the history
  3. Revert "Text change for the block change tooltip"

    This reverts commit 82df754.
    mapk committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    134b032 View commit details
    Browse the repository at this point in the history