Text change for the block change tooltip #14328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapk
requested review from
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
mapk
force-pushed
the
update/tooltip-change-block
branch
from
717e5a7
to
3b81591
Compare
…ats (#13948) * Add objects and lineFormats * Update RichText * Fix image toolbar * Update format placeholder * lineFormat => lines * concatPair => mergePair * Update selectedFormat checks * Add some extra info to create docs * Move create docs inline * Merge lines and objects * Fix typos * Add getActiveObject unit tests * Update docs * Rebase * Adjust unstableToDom arguments * Remove normaliseFormats from list functions * Update native files * Update native file
* RichText: try alternative list shortcuts * Try tooltips * Change tooltips to use text * Add inline comments * Add e2e test * Rebase
These changes add design documentation. Co-Authored-By: kjellr <[email protected]>
* Adjust document outline to use an a tag vs button * target href links directly to page anchors, remove onClick handler * update test snapshot * update snapshot * better titleNode targeting * update snapshot * update snapshot * Close the table of contents panel when a link is clicked * add deterministic block id to tests * remove redundant screen reader text * Adjust map to avoid mutating original object * update snapshot * Update packages/editor/src/components/document-outline/index.js Co-Authored-By: adamsilverstein <[email protected]> * Update packages/editor/src/components/document-outline/test/index.js remove leading _ Co-Authored-By: adamsilverstein <[email protected]> * Update packages/editor/src/components/document-outline/index.js Co-Authored-By: adamsilverstein <[email protected]> * update snapshot * update snapshots * update snapshot * update snapshots * fix up e2e tests * Fix snapshots by removing single quotes from outline links * Update packages/editor/src/components/document-outline/index.js Co-Authored-By: adamsilverstein <[email protected]> * change target to href * rename close -> closeOutline * update snapshots after property name changes * rename close/onClose -> onRequestClose for TOC, on * restore onSelect * complete renaming * Block links are only valid for the current session - remove hash after following * update snapshot * cleanup; move block id hash removal functionality up to document outline; now includes title * update snapshot * use replaceState vs pushState * use defer and import at top of file * removeURLHash as helper * remove passing event in select handler * improve doc block * Skip title in outline when title node not found * remove removeURLHash
* Plugin: Remove replace_editor filter, extend core editor * Plugin: Avoid dynamic dependencies for wp-block-library style This is handled by core in common blocks style enqueues behavior https://github.com/WordPress/wordpress-develop/blob/e421f26/src/wp-includes/script-loader.php#L2626-L2630 * Testing: Leverage saveDraft for meta boxes save
* Use <s> for strikethrough, not <del> * Update e2e test
* Add anchor link * Add anchor link to second reference
* added an interactive argument to the test-e2e script * mend * added a way to bypass certain args from Jest, reverted to normal argument passing using double dash * simplified the argument cleanup function * simplified the argument cleanup function * added a way to bypass certain args from Jest, reverted to normal argument passing using double dash * simplified the argument cleanup function * simplified the argument cleanup function * cleaned up the code by moving the prefixed arguments removal to getcliargs
…; Add: end to end tests; (#14390)
…s it (#14450) * Input Interaction: only consider selection at edge if directed towards it * Add e2e test
* Initial commit to update CheckboxControl readme These changes add design documentation. * Fix tabbing on code example
* Add thick borders to the left of blocks when they're hovred + selected. * Add thick left border to the page title. * Turn off block toolbar centering for alignwide blocks. This splits the left border in two, which looks a bit weird. * Move block breadcrump to the left side, position it on top of the block. * Clean up the block toolbar's left border. * Use inset borders on mobile. * Prevent inset borders from overlapping with full-bleed content. * Use a gray border instead of a blue one on hover. * Use a sass variable to define the left block border width * Fix breadcrumb potision for alignfull blocks. * Clean up breadcrumb position for left & right-aligned blocks. * Sync block mover animation up with the hover state. * Darken focused block borders slightly. From $light-gray-500 to $light-gray-800. * Switch to using border instead of outline for block borders. Also, change the thick left border to a solid color, to prevent weird overlap. * Make this work better with Windows High Contrast Mode * Adjust z-index of border + breadcrumb for child blocks. So that they're not overlapped by the parent block's border + toolbar. * Remove extra z-index rule from the block border. Turns out this wasn't needed anyway. * Remove extra z-index rule from the block border. Minor description cleanup. * Ensure these styles are compatible with Top Toolbar mode. * Use the new gray value for the mobile toolbar border. * Add a matching left border to the post permalink area above the title. * Improve border position for mobile screens, especially for elements that float left/right. * Remove a couple unnecessary border updates from 047e1e4. Turns out these styles can be preserved on all screen sizes with no ill effect. * Clean up bugs related to the hover + focus states of the classic editor block. * Classic Block toolbar icon cleanup. Even out margins, remove white background. * Reusable Block border cleanup. * Keeping a light border on the classic block when it's inactive. * Clean up borders on warning blocks. * Switch to a solid color border color for the permalink box. This mirrors the approach we use for block toolbars, and also ensures that we don't layer opacities and make the permalink toolbar darker than intended. * Update z-index rule name to match the one used in the latest merge. * Combine full-wide toolbar centering rules. Previously, these were declared in two separate palces. * Add a darker hover state for dark themes. * Remove the left toolbar border on mobile screens. This fixes some visual bugs with themes like TwentyNineteen, which include margins on either side of the block on mobile.
* Input Interaction: allow outer vertical edge to be selected * Add e2e test
* DOM: Limit single tabbable radio input by name * DOM: Avoid consolidating unnamed radio inputs
Add design guidelines and screenshots.
* Update MenuGroup Readme. Add design guidelines and screenshots. * Adjust introduction to be more concise.
…tenberg into update/tooltip-change-block
mapk
requested review from
aduth,
ajitbohra,
chrisvanpatten,
dmsnell,
jorgefilipecosta,
mkaz,
nerrad,
oandregal,
notnownikki,
ntwb and
Soean
as code owners
This reverts commit 82df754.
|
My rebase went harry. I'm reverting it and trying this again. Sorry about the ping to everyone. |
|
Closing this and created a new PR (#14470) b/c this is just not being friendly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10852. Editing tooltip for the Change Block icon.
How has this been tested?
Tested locally.
Screenshots
Types of changes
I changed the text from "Change block type" to "Change block type or style"
Checklist: