Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Deprecate register_tinymce_scripts #13466

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 24, 2019

Related: #11015

This pull request seeks to deprecate register_tinymce_scripts in favor of the core-equivalent wp_register_tinymce_scripts. In practice, it doesn't ever need to be called because it is executed as part of the wp_default_scripts action.

See:

Testing instructions:

Verify there is no regressions in the load and basic use of TinyMCE (e.g. paragraph block field).

@aduth aduth added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Jan 24, 2019
@aduth aduth force-pushed the remove/register_tinymce_scripts branch from cc3e0fb to e9231f8 Compare January 25, 2019 18:14
@aduth aduth mentioned this pull request Jan 25, 2019
4 tasks
@aduth aduth merged commit 896ce38 into master Jan 25, 2019
@aduth aduth deleted the remove/register_tinymce_scripts branch January 25, 2019 18:29
@youknowriad youknowriad added this to the 5.0 (Gutenberg) milestone Jan 25, 2019
daniloercoli added a commit that referenced this pull request Jan 26, 2019
…rnmobile/372-enter-key-detection-to-title

* 'master' of https://github.com/WordPress/gutenberg: (29 commits)
  Update for RangeControl documentation (#12564)
  Plugin: Deprecate gutenberg_load_list_reusable_blocks (#13456)
  Update the columns attribute in onSelectImages so that if images are removed via the media modal, the columns can't be higher than the new number of images (#13488)
  Replace the fullscreen "exit" icon with a back arrow (#13403)
  Include :visited links in button color (#12183)
  Amazon Kindle block (#13510)
  Plugin: Deprecate gutenberg_prepare_blocks_for_js (#13457)
  Add watcher on Linux: change fs to node-watch (#13448)
  Plugin: Deprecate `gutenberg` theme support (#13458)
  Datepicker: Add inValidDay support (#12962)
  Block Switcher: Render disabled button even if multi-selection (#13431)
  Plugin: Deprecate gutenberg_register_post_types (#13468)
  Plugin: Deprecate register_tinymce_scripts (#13466)
  Set minimum of words for RSS excerpt (#13502)
  Plugin: Deprecate gutenberg_get_block_categories (#13454)
  Plugin: Deprecate gutenberg_content_block_version (#13469)
  API Fetch: Expose nonce on created middleware function (#13451)
  Plugin: Remove list screens integrations (#13459)
  Plugin: Remove core-defined block detection functions (#13467)
  Spec Parser: Move generated spec parser to package (#13493)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants