Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP code merged into WordPress 5.0 #11015

Closed
5 tasks done
youknowriad opened this issue Oct 24, 2018 · 7 comments
Closed
5 tasks done

Remove PHP code merged into WordPress 5.0 #11015

youknowriad opened this issue Oct 24, 2018 · 7 comments
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone

Comments

@youknowriad
Copy link
Contributor

youknowriad commented Oct 24, 2018

Important note: Closing this issue means we update the minimum WP supported version of the plugin to 5.0. (Edit: Done in #13370)


Now that WordPress 5.0 is ready to be released, we need to start working on the next phase and ensure we don't duplicate code in the plugin.

Things that should be removed from the plugin:

See Project: https://github.com/WordPress/gutenberg/projects/23

The php files that need to remain in the plugin are:

  • Scripts registration (overriding)
  • Dynamic blocks registration
@youknowriad youknowriad added Framework Issues related to broader framework topics, especially as it relates to javascript Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Oct 24, 2018
@youknowriad youknowriad added this to the Future: Phase 2 milestone Oct 24, 2018
@youknowriad youknowriad changed the title Remove PHP code merged into 5.0 Remove PHP code merged into WordPress 5.0 Oct 24, 2018
@youknowriad youknowriad added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Oct 24, 2018
@danielbachhuber
Copy link
Member

Previously #10656

@swissspidy
Copy link
Member

Related: #12559.

@aduth
Copy link
Member

aduth commented Jan 21, 2019

we update the minimum WP supported version of the plugin to 5.0.

Pull request: #13370

  • REST API endpoints and tweaks

Pull request: #13408

  • Block parsing, rendering utilities

Started on this one. Interestingly the wordpress_phpunit Docker image still uses WordPress 4.9.x , so naturally will encounter a fair number of fatal errors when trying to remove functions like register_block_type. Will definitely need to update this, but I'm not certain the process for doing so.

Edit: I guess my local Docker containers were very much out of date, and I'd wrongly relied on the install-docker.sh script to update them. Destroying it via docker-compose rm wordpress_phpunit and re-running the Docker install script seems to install the latest version as expected. I assume this isn't a problem for Travis, as the containers are created from scratch for each build?

Pull request: #13412

@aduth
Copy link
Member

aduth commented Jan 23, 2019

php files adding the MetaBoxes support

Pull request: #13449

Miscellaneous core compatibility (lib/compat.php)

Pull request: #13442

@aduth
Copy link
Member

aduth commented Jan 24, 2019

This is turning out to be a more significant effort.

Here's a project instead: https://github.com/WordPress/gutenberg/projects/23

@aduth
Copy link
Member

aduth commented Mar 13, 2019

Unless I've missed something, I'd now consider this effort concluded with the last major merge in #13569 (future deprecation removals notwithstanding).

https://github.com/WordPress/gutenberg/projects/23

@aduth aduth closed this as completed Mar 13, 2019
@youknowriad
Copy link
Contributor Author

Thanks Andrew, nice work here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

4 participants