Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fix second welcome tip instructs the user to open a control that's already open. #12911

Merged
merged 3 commits into from
Feb 7, 2019

Conversation

naogify
Copy link
Contributor

@naogify naogify commented Dec 15, 2018

Description

I fixed the text of second welcome tip's instruction Click “Settings” to open it to Click “Settings” allows toggling the sidebar.

https://github.com/WordPress/gutenberg/blob/master/packages/edit-post/src/components/header/index.js#L72

Discussed in here.

#12359

Types of changes

Change text.

@naogify
Copy link
Contributor Author

naogify commented Dec 16, 2018

I thought the description above is not enough. I want to add an additional explanation below.

Additional explanation

Problem

The second welcome tip instructs the user to open the Settings panel. This panel is already open, and following the instruction causes it to close.

(Quoted from : #12359 ).

1

How I fixed it.

Changing the instruction text to explain software behavior properly.
I changed Click “Settings” to open it.' to Click “Settings” allows toggling the sidebar..

2

How to check.

  1. Git clone the fix/second-welcome-tip-instruction branch in local environment.
  2. Ensure the localStorage in your browser is clear for your domain, so that tips appear (related: Tips: status should be user-based not browser-based #8052).
  3. Open the block editor.
  4. .Follow the instruction, then you will see the second welcome tip.
    (Second and third items of this list are quoted from : #12359 ).

How has this been tested?

I visually checked it in local environment and tested it by $ npm run test with 5.0.1.

Types of changes

Changing the instruction text.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@gziolo gziolo added [Feature] NUX Anything that impacts the new user experience [Type] Copy Issues or PRs that need copy editing assistance labels Dec 16, 2018
@jorgefilipecosta jorgefilipecosta added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Dec 17, 2018
@michelleweber
Copy link

I would be even more specific:

Click to cog icon to toggle the sidebar open and closed.

@naogify
Copy link
Contributor Author

naogify commented Dec 18, 2018

@michelleweber
I agree with making the copy more specific. I think your sentence is better than mine. Does anyone have other suggestion?

@gziolo
Copy link
Member

gziolo commented Jan 25, 2019

Let's update with the suggestion from @michelleweber and proceed as there was no other version proposed.

@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 25, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated with Click the cog icon to toggle the sidebar open and closed. as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] NUX Anything that impacts the new user experience Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants