Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second welcome tip instructs the user to open a control that's already open #12359

Closed
johnbillion opened this issue Nov 27, 2018 · 3 comments
Closed

Second welcome tip instructs the user to open a control that's already open #12359

johnbillion opened this issue Nov 27, 2018 · 3 comments
Labels
[Feature] Document Settings Document settings experience [Feature] NUX Anything that impacts the new user experience Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@johnbillion
Copy link
Member

Describe the bug

The second welcome tip instructs the user to open the Settings panel. This panel is already open, and following the instruction causes it to close.

Tested with WordPress 5.0 RC.

To Reproduce

Steps to reproduce the behavior:

  1. Ensure the localStorage in your browser is clear for your domain, so that tips appear (related: Tips: status should be user-based not browser-based #8052).
  2. Open the block editor.
  3. Follow the instruction on the second welcome tip: Click “Settings” to open it.
  4. Observe that the settings panel is now closed, because it was already open.

Expected behavior

The initial settings panel state and the information on the corresponding welcome tip should match.

Screenshots

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Chrome
  • Version: 70
@johnbillion johnbillion added [Type] Bug An existing feature does not function as intended [Feature] Document Settings Document settings experience [Feature] NUX Anything that impacts the new user experience labels Nov 27, 2018
@johnbillion
Copy link
Member Author

Addendum: This tip also references a control called Settings, which is in fact represented in the UI by a cog icon.

@jorgefilipecosta
Copy link
Member

One possible fix for the issue may be changing the text e.g: Clicking "Settings" allows to toggle the sidebar."
I'm adding the good first issue label.

@jorgefilipecosta jorgefilipecosta added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Dec 3, 2018
@naogify naogify mentioned this issue Dec 15, 2018
Merged
@youknowriad
Copy link
Contributor

closed by #12911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Document Settings Document settings experience [Feature] NUX Anything that impacts the new user experience Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnbillion @youknowriad @jorgefilipecosta