Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into mobile #12796

Merged
merged 35 commits into from
Dec 11, 2018
Merged

Merge master into mobile #12796

merged 35 commits into from
Dec 11, 2018

Commits on Dec 6, 2018

  1. RichText: fix onSetup doc (#12607)

    ellatrix authored and mtias committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    387bb77 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Update broken links (#12660)

    * Update broken links
    
    There was 2 broken links. I changed same way with Data Module Reference page.
    
    * Update docs/designers-developers/developers/block-api/README.md
    
    Co-Authored-By: cagdasdag <[email protected]>
    
    * Update docs/designers-developers/developers/block-api/README.md
    
    Co-Authored-By: cagdasdag <[email protected]>
    cagdasdag authored and chrisvanpatten committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    d7eaeb9 View commit details
    Browse the repository at this point in the history
  2. Docs: Update Glossary (#12479)

    * Update glossar with missing terms
    
    * Convert glossary to use dl/dt/dd dtags. Fixes #9976
    
    * Fix TinyMCE link
    
    * remove spacing around tags
    
    * Add template definition, with link
    
    * Updates per review
    
    * Update docs/designers-developers/glossary.md
    
    Co-Authored-By: mkaz <[email protected]>
    mkaz authored and chrisvanpatten committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    50cafdd View commit details
    Browse the repository at this point in the history
  3. Add documentation for safeDecodeURI() and filterURLForDisplay() (#…

    …12570)
    
    * Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`
    
    * Whitespace
    
    * Consistant Capit… i mean capitalization
    
    * Oxford comma
    
    Co-Authored-By: georgeh <[email protected]>
    georgeh authored and chrisvanpatten committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    6b8cd54 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f5b18c2 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2018

  1. Configuration menu
    Copy the full SHA
    7f118dd View commit details
    Browse the repository at this point in the history
  2. Optimize isViewportMatch (#12542)

    ellatrix authored and youknowriad committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    715af6b View commit details
    Browse the repository at this point in the history
  3. Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

    * Cache createBlock call in isUnmodifiedDefaultBlock
    
    * Invalidate cache when default block name changes
    
    * Merge ifs
    ellatrix authored and youknowriad committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    8e772be View commit details
    Browse the repository at this point in the history
  4. Font Size Picker: Use a menuitemradio role and better labels. (#12372)

    * Use a menuitemradio role and better labels.
    
    * Restore Button and remove MenuItem import.
    
    * Use template literals.
    afercia authored and youknowriad committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    d385f3d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    13459da View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2018

  1. Fix e2e tests after the WordPress 5.0 upgrade (#12715)

    * Fix e2e tests after the WordPress 5.0 upgrade
    
    * Remove the php unit tests testing the WP5.0 core instead of the plugin
    youknowriad committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    1d5fa32 View commit details
    Browse the repository at this point in the history
  2. Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

    Hiding disabled meta boxes by setting `element.style.display = 'none'`
    interferes with plugins like ACF which rely on being able to show and
    hide meta boxes using `$.hide()` and `$.show()`.
    
    Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
    class ensures that we don't interfere with third party code.
    noisysocks authored and youknowriad committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    06c4dc3 View commit details
    Browse the repository at this point in the history
  3. Add a word-wrap style to the facebook embed preview screen (#11890)

    * Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary
    
    * Fix typo and missing space in scss comment
    brentswisher authored and youknowriad committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    29cfa83 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    607c46f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    85d83ad View commit details
    Browse the repository at this point in the history
  6. Fix: Problems on Media & Text block resizing; Load wp-block-library s…

    …tyles before wp-edit-blocks. (#12619)
    jorgefilipecosta authored and youknowriad committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    9f6dc6d View commit details
    Browse the repository at this point in the history
  7. Get wordcount type from translation (#12586)

    * get wordcount type from translation
    
    * Add description to explain the options for wordcount type
    
    * Added mylsef into contributors.md. :)
    miya0001 authored and youknowriad committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    779a18e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a12fcec View commit details
    Browse the repository at this point in the history
  9. Fix issue where default appender has icons overlaying the text (#12536)

    * Fix issue where default appender has icons overlaying the text
    
    This fixes #11425.
    
    It adds padding to the right of the default block appender to fit 3 icons.
    
    * chore: Tweak spelling
    jasmussen authored and youknowriad committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    42bf375 View commit details
    Browse the repository at this point in the history
  10. Classic Block: set correct focus back after blur (#12415)

    * Classic Block: set correct focus back after blur
    
    * Add e2e test
    
    * reset bookmark on mousedown and touchstart
    
    * e2e: Look for aria-label="Add Media" rather than "Insert Media"
    ellatrix authored and mcsf committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    2f4317c View commit details
    Browse the repository at this point in the history
  11. RichText: only replace range and nodes if different (#12547)

    * RichText: only set range if different
    
    * Check rangeCount
    
    * Also compare nodes
    
    * Add e2e test
    
    * Simplify
    
    * RichText: Document isRangeEqual
    
    * Testing: RichText: Assure subscriber removal
    
    * Unsubscribe in page.evaluate
    ellatrix committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    f23282b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c63bb7d View commit details
    Browse the repository at this point in the history
  13. When a post is saved, check for tinymce and save any editors. (#12568)

    * When a post is saved, check for tinymce and save any editors.
    
    * Importing tinymce and using tinyMCE vs the object stored in window.tinymce.
    
    * Updated version number and changelog.
    
    * no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.
    
    * Using typeof to check for tinyMCE and fixed issues brought up in travis run.
    
    * using window.tinyMCE again to avoid warning RE undefined var
    
    * Restore the package.json version.
    
    * Add e2e tests for the custom wp_editor metaboxes
    ideadude authored and youknowriad committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    4ea5094 View commit details
    Browse the repository at this point in the history
  14. Rename functions, removing gutenberg_ prefix (#12326)

    * Rename functions, removing gutenberg_ and prefixing with wp_
    
    * Remove wp_ prefix to match core
    
    * Remove function check per review
    mkaz authored and youknowriad committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    4bb3b0c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e7fb179 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    b44a2f1 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. Fix for #11663 (#12728)

    * Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute
    
    * Fixed Deleting an HTML Anchor attribute leaves an empty
    saleehk authored and noisysocks committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    47736a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a5486d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b6949b9 View commit details
    Browse the repository at this point in the history
  4. Try: JS Console warning for when in Quirks Mode (#12575)

    * Try: JS Console warning for when in Quirks Mode
    
    This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.
    
    This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.
    
    The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.
    
    The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:
    
    ```
    [Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
    ```
    
    It also augments the documentation to add a note about this.
    
    * Move warning to index.js
    
    * Remove try/catch.
    
    * Tweak: Remove redundant [warning] in warn call
    jasmussen committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    40d1282 View commit details
    Browse the repository at this point in the history
  5. Organizing screenshot assets for the block tutorial inside the design…

    …ers-developers directory in the repo (#12745)
    terriann authored and chrisvanpatten committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    b7e343d View commit details
    Browse the repository at this point in the history
  6. Rename backwards compatiblity to backward compatibility (#12751)

    * Rename backwards compatiblity to backward compatibility
    
    * Remove package-lock from commit
    
    * Update CONTRIBUTING.md
    
    Co-Authored-By: mkaz <[email protected]>
    
    * Update CONTRIBUTING.md
    
    Co-Authored-By: mkaz <[email protected]>
    
    * Whitespace in manifest
    mkaz authored and chrisvanpatten committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    8790bce View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Configuration menu
    Copy the full SHA
    09a9052 View commit details
    Browse the repository at this point in the history
  2. Update node-sass to 4.11.0 to support Node.js 11 (#12541)

    ## Description
    Fixes #12539 by updating node-sass to support Node.js 11.
    
    ## How has this been tested?
    Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.
    
    ## Types of changes
    Minor dependency bump to support Node.js 11.
    
    ## Checklist:
    - [x] My code is tested.
    - [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
    - [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
    - [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
    swissspidy authored and ntwb committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    1a1dc7c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4759b9b View commit details
    Browse the repository at this point in the history