-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks overlap meta boxes on posts #11378
Comments
I can confirm this issue. Insert a long content into the classic block and the meta boxes will overlap this block. |
Can anyone of you test with master, I'm not being able to reproduce this issue, it might have been fixed. |
It persists. |
It could be a windows issue? Can you test with this zip https://builds.danielbachhuber.com/gutenberg-nightly.zip |
With the nightly build it is working 👍 |
Thanks for the test, that's great news. I'm going to close this, this will be released in the 4.3 version. |
I installed Gutenberg 4.3.0-alpha-1ac70e1 on my 4.9.8 site and the problem persists. |
@DeveloperWil Interesting, I'm reopening so we can investigate more, but it's not going to be an easy fix if we can't reproduce reliably. |
@DeveloperWil could you deactivate Advanced Custom Fields PRO and I had also tested (like you) with windows 10 64bit and Chrome, WP 4.9.8 etc and Gutenberg 4.3.0-alpha-1ac70e1 (but nothing else installed) and the bug has been fixed. |
Firefox registered a lot of metaboxes. My issue from #11482 does not really persist. |
This is not fixed in Gutenberg 4.3.0 and it is not fixed in WP 5.0-beta3-43891. |
I'm not sure if this is related, but if it is, you can replicate this by enabling the Sharing Buttons in the Jetpack plugin. As you can see in the screenshot, the sharing buttons meta box overlaps the Gutenberg blocks. This could however be a bug in Jetpack (and the All in One SEO plugin, which has the same issue, as you can see in the image) If this is a bug in those two plugins, please let me know and I'll log issues with each project. |
I am crossreferencing this issue from TwentyNineteen WordPress/twentynineteen#599 as this issue also seems to address metaboxes and the editor field (while from a slightly different angle) |
I've found a way to reproduce, however only on 4.4, not in master. So it's worth trying to figure out when/how it was fixed.
Result of the above steps in 4.4: Result of the above steps in master: ☝️ Note that the coral color is one i added in the debugger, to the I have tested this in Chrome and Firefox on Windows and Mac. When I initially investigated, it looked like it was bad flexing of the |
Would appreciate if someone could test this issue in master and see if the issue persists there. |
As it turns out my 'bug' was related to the Divi theme and not the Jetpack or All in One SEO plugins. Activating Twenty Seventeen and running the master branch of the plugin, everything works fine. |
Thanks for the followups and testing. |
While I see that this bug is closed, I too have this issue with the Meta Blocks floating over the WP editor blocks. I tried disabling my current theme (Theme.co Pro) as well as Yoast. This was on a dev site with minimal plugins. I will try deactivating all plugins to see if I can identify a conflict. I'm using 5.0-RC1. Updated: Found the conflicting Plugin - Shortcake (Shortcake UI) - https://wordpress.org/plugins/shortcode-ui/ |
There are multiple issues opened with this same problem and there seem to be multiple sources. I ran into it as well, for me the issue was not silent php errors. The issue was that my theme css had a rule setting the body element's height to 100%. The way Gutenberg handles editor styles is by transforming your theme's css:
The result in my case is that |
Thank you for sharing that, @bitwitch! @youknowriad this feels like something we should mitigate. Do you think we should either remove that height when rewriting, or create a separate rule in the new "normalization" stylesheet that overrides the height to always be auto, perhaps with an !important and an inline comment? |
May I ask why there's a The main reasons for the fact that the editor styles are opt-in in Gutenberg is the fact that the old editor styles are not usable directly. Theme authors should check whether their styles are "compatible" and then enable them. I'm not sure we should introduce hacks like this. |
The primary reason to do this is usually to create websites that use the full height of the browser window for elements. For example if you have an "above the fold" splash element on your homepage, one that's always 100% tall. Or if you need to bottom align something on a page that doesn't scroll. Admittedly this is very much a front-end thing, and not something you would normally put in the editor style. In that vein, I buy your argument indeed. My thought in perhaps opening a separate ticket is to take yet another small baby step towards a future where the editor style doesn't have to be different from the frontend style. Though perhaps this particular one is a task to revisit at a later time. |
The reason for such a rule in my case is because we do not use a separate stylesheet for the editor. We minify the entire site's css into a single file, including all the css for custom blocks. The body height: 100 rule is for elsewhere on the site. My intention in posting was to help out others who may have the same source of problem as me, not necissarily to recommend introducing a workaround on gutenberg's end. |
I don't have much to add other than to say I have had the same issue (Yoast SEO blocking text on the page editor) to the point of making it barely usable. |
@PhotoCoog usually this is a plug-in issue. Can you open the JavaScript console and see if there are any messages there? In Chrome, mac it's ⌘⌥J, in Firefox it's ⌘⌥K, in Safari you first have to enable it, instructions here: https://support.airtable.com/hc/en-us/articles/232313848-How-to-open-the-developer-console Depending on whether or not there's a message in the console, the next steps depend on that. Thanks. |
It has the following which actually mentions the issue! Any way to fix it? JQMIGRATE: Migrate is installed, version 1.4.1 This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening . Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins. |
@PhotoCoog Thanks for looking! This means there there is a plugin or a theme on your website that needs an update. One way to test is disable plugins one by one and figure out which one makes the editor render correctly, but I realize this is tricky to do on a production site. As an alternative, feel free to send me a list of the plugins you're using, and I can test them one by one for you, and see which one causes the issue. Once we find the culprit, I can reach out to the developer to suggest a fix. |
Fix this issue from style for the dashboard. Add this hook in your theme, functions.php // Add style for dashboard, overlap meta boxes on posts(editor) function custom_metabox_style() |
@rendergraf Can you open the JavaScript console and let me know if you see a warning there? In Chrome, mac it's ⌘⌥J, in Firefox it's ⌘⌥K, in Safari you first have to enable it, instructions here: https://support.airtable.com/hc/en-us/articles/232313848-How-to-open-the-developer-console I've tried that overflow trick in the past, and there are unfortunate side effects to it. Additionally, if you do see a warning in the JS console, it means there is a conflict with a plugin, and the real fix is to fix that plugin. |
@jasmussen in the console does not show any error related to admin_head. everything works correctly |
Interesting! Thank you for getting back to me with that. If you open the web inspector, is the first thing in the document the doctype? I.e. <!doctype html>? Or is there anything before that? |
No, in my case is: ... class="wp-admin wp-core-ui ...morePlease, if you need more information about hook admin_head, can you see documentation oficial: I hope it helps you |
In my case the problem was in a CSS code echoed on admin_menu hook, changed the hook to 'admin_bar_menu' and everything seems to be okay |
that works but why it is not fixed in WP itself still. |
I run in this problem yesterday, after i upgraded to Google Chrome Version 77.0.3865.75 on my mac. I disabled all Browser Plugins, the Problem still exists. The editing is working normal on Google Chrome 76. I upgraded Chrome to Version 77 on this machine and the problem also appears. I also tested with Chrome Canary Version 79.0.3912.0 (Offizieller Build) canary (64-Bit) without problems. And i tested with firefox. Also no problems. |
Upper solution doesn't help me, i try edit this hook and its works for me.
|
I confirm. Plugins: Yoast, ACF This piece of code fixes a bit Chrome behaviour
|
Works for me. |
Can confirm this issue exists in Chrome 77.0.3865.75 on MacOS. The above solutions regarding adding
|
@TylerB24890 Best |
Happening on 4 sites in 5.2.3 for us. TylerB's fix worked for me, though you should remove the // comment since that's not a valid CSS comment. |
Worked for me! |
|
You can also use:
With this the editor will show its content always, and not shrink down when your mouse enters a meta-box. |
Here is what fixed it for me, which is combinition of both solutions. add_action( 'admin_head', 'fix_overlapping_blocks' );
function fix_overlapping_blocks() { // fix the admin edit post with metabox
?>
<style>
#editor .edit-post-layout__content {
display: block;
}
#editor .edit-post-layout__content .edit-post-visual-editor {
flex-basis: auto; /* override the default flex-basis: 100%;*/
clear: both;
}
</style>
<?php
} |
Fix with this: Enqueue only on admin: |
When composing a post, the Gutenberg blocks overlap the meta boxes at the bottom of the post. I cannot enter content into those blocks so I cannot complete my post using the new editor.
All meta boxes from Advanced Custom Fields Pro are shown and the other is Yoast SEO Premium.
I presume because there is no document template option that ACF conditionals are not working so it shows all those meta boxes, but that's a separate issue.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Clear separation of the content editor and the document meta boxes.
Screenshots
You can see the overlapping Title block and the eBooks and Yoast SEO meta boxes from this screenshot.
Desktop (please complete the following information):
Additional context
WordPress 4.9.8
Advanced Custom Fields PRO 5.7.7
Yoast SEO Premium 8.3
The text was updated successfully, but these errors were encountered: