Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint: remove browser env #1008

Merged
merged 1 commit into from
Jun 2, 2017
Merged

eslint: remove browser env #1008

merged 1 commit into from
Jun 2, 2017

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Jun 2, 2017

To prevent bugs like #1007, I would suggest removing browser from eslint settings.

@ellatrix ellatrix requested a review from aduth June 2, 2017 15:39
aduth
aduth approved these changes Jun 2, 2017
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board 👍

@aduth
Copy link
Member

aduth commented Jun 2, 2017

@ntwb Perhaps of interest to you. See also #1007, #1007 (comment) .

@ellatrix ellatrix merged commit ce9abd8 into master Jun 2, 2017
@ellatrix ellatrix deleted the try/eslint-no-browser branch June 2, 2017 18:07
@aduth aduth mentioned this pull request Jun 13, 2017
Merged
@aduth aduth mentioned this pull request Aug 4, 2017
Merged
@ntwb ntwb mentioned this pull request Mar 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellatrix @aduth