Pass down focus prop in Toolbar component

[ellatrix]

Closes #975. Props @BE-Webdesign!

[ellatrix]

I'm not sure why the linter didn't catch this.

[aduth]

I'm not sure why the linter didn't catch this.

Was just about to ask the same thing 😄

[BE-Webdesign]

Yeah, no idea, good thing we are starting to add tests in.

[aduth]

Guessing it was considering it as the window global focus?

https://developer.mozilla.org/en-US/docs/Web/API/Window/focus

[BE-Webdesign]

Guessing it was considering it as the window global focus?

That sounds like the culprit.

[ellatrix]

Huh, didn't even know that existed.

[ellatrix]

I'm all for removing the browser setting and explicitly getting from the window object...

[aduth]

I'm all for removing the browser setting and explicitly getting from the window object...

Worth exploring. Are window and document considered permitted only by that env flag though? Webpack remaps global as window if I recall correctly, so at worst we'd have global.getComputedStyle, global.document.querySelector, etc.

[ellatrix]

Actually, I removed the browser flag, and it still does not error.

[aduth]

Might be picking up default from eslint-config-wordpress, which we extend:

https://github.com/WordPress-Coding-Standards/eslint-config-wordpress/blob/25114c9/index.js#L4

In which case we'd need to explicitly set it to false.

[ellatrix]

@aduth Perfect! :)