Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant rule. #10021

Merged
merged 2 commits into from
Sep 19, 2018
Merged

Remove redundant rule. #10021

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be41112
Remove redundant rule.
Sep 19, 2018
0119c8c
Address feedback.
jasmussen Sep 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions edit-post/components/header/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,11 @@
left: 0;
right: 0;

// mobile edgecase for toolbar
// Stick the mobile toolbar way to the top, because the adminbar is not fixed either.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "way to the top" mean? I think it's a turn of phrase but I don't really understand 🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think "adminbar" should be "admin bar".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches, both of them.

top: 0;
position: sticky;

// on mobile the main content area has to scroll
// otherwise you can invoke the overscroll bounce on the non-scrolling container, causing (ノಠ益ಠ)ノ彡┻━┻
// On mobile the main content area has to scroll, otherwise you can invoke the overscroll bounce on the non-scrolling container.
@include break-small {
position: fixed;
padding: $grid-size;
Expand Down Expand Up @@ -52,14 +51,12 @@
}

.edit-post-header .components-button {
border-radius: $radius-round-rectangle;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is the actual redundant rule and the rest of the comment tweaks happened just because you were already tidying things up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. A good friend once suggested how these comments can look their best.


// header toggle buttons
// Header toggle buttons.
&.is-toggled {
color: $white;
}

// put the gray background on a separate layer, so as to match the size of the publish button (34px)
// Put the gray background on a separate layer, so as to match the size of the publish button (34px).
&.is-toggled::before {
content: "";
border-radius: $radius-round-rectangle;
Expand Down