Remove redundant rule. #10021
Merged
Remove redundant rule. #10021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue reported in #9588 (comment). It also polishes the comments a bit.
tofumatt
approved these changes
Sep 19, 2018
| @@ -11,12 +11,11 @@ | |||
| left: 0; | |||
| right: 0; | |||
|
|
|||
| // mobile edgecase for toolbar | |||
| // Stick the mobile toolbar way to the top, because the adminbar is not fixed either. | |||
There was a problem hiding this comment.
What does "way to the top" mean? I think it's a turn of phrase but I don't really understand 🤷♂️
There was a problem hiding this comment.
Also I think "adminbar" should be "admin bar".
There was a problem hiding this comment.
Good catches, both of them.
| @@ -52,14 +51,12 @@ | |||
| } | |||
|
|
|||
| .edit-post-header .components-button { | |||
| border-radius: $radius-round-rectangle; | |||
There was a problem hiding this comment.
I'm guessing this is the actual redundant rule and the rest of the comment tweaks happened just because you were already tidying things up?
There was a problem hiding this comment.
Correct. A good friend once suggested how these comments can look their best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue reported in #9588 (comment).
It also polishes the comments a bit.