Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate "appearance" and "settings" tabs if there are no settings controls #47463

Closed
richtabor opened this issue Jan 26, 2023 · 5 comments · Fixed by #47474
Closed

Consolidate "appearance" and "settings" tabs if there are no settings controls #47463

richtabor opened this issue Jan 26, 2023 · 5 comments · Fixed by #47474
Assignees
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi

Comments

@richtabor
Copy link
Member

What problem does this address?

In the current UI, the split Appearance and Settings tabs always show up in the Inspector sidebar. A proper example of this is the Paragraph block, which has all Appearance controls, and no Settings controls (other than the standard "Advanced" panel). We don't need a tab just for Advanced.

What is your proposed solution?

Let's improve this by not showing the separate Appearance and Settings tabs, for blocks that do not have any controls available in Settings. And instead render the "Advanced" panel at the foot of the style controls.

This change also allows us to experiment with having the Settings tab set as default (if there is a Settings panel). I'll follow-up with another issue on that functionality.

Current:

CleanShot 2023-01-26 at 10 03 22

Proposed:

CleanShot 2023-01-26 at 10 03 51

@richtabor richtabor added [Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks Needs Dev Ready for, and needs developer efforts [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jan 26, 2023
@richtabor richtabor changed the title Don't show separate appearance and settings tabs, if there are no settings controls Consolidate "appearance" and "settings" tabs if there are no settings controls Jan 26, 2023
@ndiego
Copy link
Member

ndiego commented Jan 26, 2023

Another option would be to render the Advanced panel in the Settings tab but have it open. I'm just thinking of third-party plugins that might add additional Settings panels. 🤔

@richtabor
Copy link
Member Author

I'm just thinking of third-party plugins that might add additional Settings panels. 🤔

Then the Appearance/Settings tabs would render. :)

@aaronrobertshaw
Copy link
Contributor

Another option would be to render the Advanced panel in the Settings tab but have it open.

We did explore having the Advanced panel open by default if it was the only item in the Settings tab in #46024. Unfortunately, there were some technical limitations in detecting this scenario.

Alternatively, having the advanced panel open by default when under the settings tab, regardless of other settings, wasn't desirable either.


While working on this issue, I encountered a scenario where a block with both list view and styles tabs might only have the advanced panel within the settings tab. The primary use case outlined in this issue revolves around a block without the list view tab, e.g. paragraph. The results, in that case, are no tabs being rendered in the sidebar.

Should we still render the advanced panel under the settings tab if a block has other tabs to display? I'm not sure how well the advanced panel would fit under the list view or styles tabs or the tab panel containing the two.

@hanneslsm
Copy link

hanneslsm commented Jan 27, 2023

I was trying to recreate the issue and then I realised that I was in the Site editor. Interestingly there is no Settings Tab there implemented (yet ?), so this issue interestingly provides consistency between Block and Site Editor. This might be something to be considered when creating the issue for experimenting having the Settings tab set as default.

(Site editor: Editing the themes. Block editor: Editing posts and pages. I do not know what the correct wordings here are.)

@aaronrobertshaw
Copy link
Contributor

Thanks for reporting what you're seeing @hannesdev 👍

Interestingly there is no Settings Tab there implemented (yet ?), so this issue interestingly provides consistency between Block and Site Editor.

Can you confirm that you see a Settings tab in the Post Editor but not in the Site Editor?

With Gutenberg 15.0 installed and active I can see the tabs in both editors. Prior to Gutenberg 15.0 the tabs were a Gutenberg experiment that you'd need to enable via Gutenberg > Experiments from WP Admin.

Here's what I see in the Site Editor:

Screenshot 2023-01-30 at 12 19 18 pm

@github-project-automation github-project-automation bot moved this from 📥 Todo to 🔎 Needs Review in WordPress 6.2 Editor Tasks Jan 30, 2023
@ndiego ndiego moved this from 🔎 Needs Review to ✅ Done in WordPress 6.2 Editor Tasks Jan 30, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
@priethor priethor removed the Needs Dev Ready for, and needs developer efforts label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants