Cover block: consolidate settings into one panel and remove Settings

[annezazu]

Description

With the addition of split settings #40204 followed by the work to consolidate the settings when there's only an Advanced section #47463, the Cover block shouldn't show split options. Right now, it does. Adding to 6.2 board since this was introduced in this release cycle.

Step-by-step reproduction instructions

1. Add a cover block.
2. Notice that the settings are split but the settings tab only shows advanced section.

Screenshots, screen recording, code snippet

Environment info

• WP 6.2 RC2
• No GB

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[annezazu]

@ndiego correctly noted that this is because when you add an image settings, the advanced sections is that used:

I wonder if there's a way to grey out these options? Unclear but leaving open for now! @jasmussen in case you have more thoughts here.

[richtabor]

There are now layout controls under the block's settings tab in trunk (#45326). There's no real feedback with them available as a placeholder state though (don't think it warrants adding/removing tabs based on placeholder state).

When its supported.

[jasmussen]

Thanks for creating the issue, and for all the detailed followup. I initially reproduced this on 6.1 + the latest (as of a couple of days ago) Gutenberg plugin.

It was a bit of a quick observation, I will note — but my immediate instinct was: something's not working, because the tabs inspector tabs are only supposed to show if there are settings panels in addition to the Advanced panel.

With these followup notes, however, it's clear that cover has both layout, and when an image is used, "Image settings" (which on a small detail note we could just call "Image", perhaps even "Background").

Just confirming:

In that light, I'd happy to close this one, as the plugin experience should be correct again next release.

[annezazu]

What you show above seems to be correct. While the initial issue is what will ship with 6.2, this ensures iteration in the future via the plugin. Closing out!