Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Consider having the responsive option on by default #34511

Closed
Tracked by #35521
annezazu opened this issue Sep 2, 2021 · 3 comments · Fixed by #35917
Closed
Tracked by #35521

Navigation Block: Consider having the responsive option on by default #34511

annezazu opened this issue Sep 2, 2021 · 3 comments · Fixed by #35917
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Sep 2, 2021

What problem does this address?

This was brought up as part of the ninth call for testing for the FSE Outreach Program:

Almost seems like the responsive setting should be toggled ON by default. Not sure if we can leverage smarter defaults, but if it exists within a Header template part, it should be ON.

This seems worth exploring as the default state.

What is your proposed solution?

Enable the navigation block to have the responsive menu on by default :) Curious what you think @jasmussen as I imagine this has been thought about. I tried to look through both open and closed issues but couldn't find anything specifically related beyond the initial discussion including you wanting it to be on by default: #22824 (comment)

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Sep 2, 2021
@jasmussen
Copy link
Contributor

Thanks for creating this, yes, we definitely want this on by default. The reason it isn't yet, is that we wanted to make sure and work out any kinks in it first. But it's slowly stabilizing.

I do wonder if we want to address #33273 and #31957 first, though. What do you think, @vcanales? Happy to pair on all of this by the way!

@jasmussen
Copy link
Contributor

CC: @vcanales Do you think it's time to look at this one? I think it could be!

@jasmussen
Copy link
Contributor

Took a stab in #35917.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants