-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools for grouping PRs by focuses #27448
Comments
Based on the phase 2 focuses and site editing milestones, this is the first draft I've come up with (will update as feedback comes):
cc @mtias @annezazu @youknowriad @draganescu @karmatosed @mapk what do you think of this? I'm mostly unsure about what to do with the [Focus] Screen: menu and [Focus] Navigation block. |
Don't let my feedback block you, these things can evolve over time. Also it would be good to have a way to tell the changelog script to mark some focuses as experimental and automatically put things there even if the "[type] experimental" label was not put on the PR. |
Great idea, some comments regarding technical details for the transition:
There is [Feature] Full Site Editing that is applied to most of the existing issues related to FSE. It might need only renaming. |
Thanks so much for doing this and getting this rolling!
I'd recommend using
I agree with @youknowriad here as I think it would help a ton to have consistency in FSE related work as it's not always obvious at a glance if someone is new. This might also help drive home that FSE is actually a collection of work rather than "one project". |
I'm not sure I understand how [Focus] should be used and what happens when it's no longer a focus but an established product area (like patterns). |
OK, did a first-round and integrated your comments, this is the current proposal.
@mtias I see them as short-lived, and they should be renamed back when they're no longer a focus. For example:
Having a common prefix @gziolo I'm not opinionated about the specific names, but it's important to me that all of the labels have the same prefix, otherwise, we don't fix the discoverability issue. Happy to consider shorter prefixes than Open the second round of feedback! |
I was only concerned by 3 labels that have both feature and screen keywords. I don't think that it's a focus really, it's just a way to provide more context or grouping for issues. |
Yes, the main thing for me here is that I hope we can get back one hour or so from the time we spend preparing the changelogs. Doesn't solve everything but might help put things in the right place and the right section. |
@youknowriad @nosolosw the customizer focus should be separate from the screens as the core of the matter there is totally different. For the screens the focus is to improve the experience those screens offer for their function and to add block management support. For the customizer the focus is to allow the customizer to "talk" to the block editor so that we can get a live preview of block edits and also to create a good experience of block editing with live preview. Therefore:
|
Thanks for the feedback, folks! While I like the clarity this kind of "grouping" could bring, it also comes with some downsides (some management when the focuses change, people involved in the issues/PRs still want the existing labels and know what they should use, etc). So, it doesn't sound like creating this new set of labels is something people would find valuable at the moment. This is what I'd like to do as the next steps:
|
ok, got #27744 ready ― it improves a bit the changelog organization. |
#27744 has landed. Updated the tasks in the issue description. |
There hasn't been activity on this for years now, so I'm closing. |
The tool that we use for Gutenberg releases comes with a changelog generator that pulls the title of the PRs bundled in the corresponding milestone and groups them together (see releases). Curating this changelog is now the more time-consuming part of the release process, so it'd be convenient to streamline.
Additionally, we now have a few sources for keeping up with all the work that is going on, see:
and they don't always group the info in the same way. By grouping the info in all places into the same focuses we have for phase 2 and site editing milestones, there'll be more clarity around what's going on in each area.
Tasks
Create/Rename existing set of labels by focus. See phase 2 focuses, and site editing milestones.Changelog generator: update how it groups the PRs.The text was updated successfully, but these errors were encountered: