Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Navigation block ] Remove the block navigator in the sidebar #20846

Closed
karmatosed opened this issue Mar 12, 2020 · 9 comments
Closed

[ Navigation block ] Remove the block navigator in the sidebar #20846

karmatosed opened this issue Mar 12, 2020 · 9 comments
Assignees
Labels
[Block] Navigation Affects the Navigation Block Needs Dev Ready for, and needs developer efforts

Comments

@karmatosed
Copy link
Member

There are 2 navigator interfaces for the navigation block, in the toolbar and the sidebar. I would recommend removing one of them. I actually like the sidebar for this as it feels a great place, there are also some good issues to iterate that. Although, I also think the modal works well. I'm a bit torn which way to recommend, but I do feel just one is better.

nav-multiplenavviews

@karmatosed karmatosed added the [Block] Navigation Affects the Navigation Block label Mar 12, 2020
@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Mar 12, 2020
@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Mar 13, 2020

I think the main Block Navigation menu should be souped up with additional functionality (think Divi Layers View; see #11408) and turned into a pinnable sidebar. If that happened, I would prefer removing the Navigation block's copy of that UI entirely, or perhaps revamping it to be more specific to the block by including the ability to edit link titles and URLs straight from that interface... not unlike the current wp-admin Menus UI. See #20748.

@karmatosed karmatosed added the [Priority] High Used to indicate top priority items that need quick attention label Apr 7, 2020
@karmatosed karmatosed self-assigned this Apr 7, 2020
@karmatosed
Copy link
Member Author

@ZebulanStanphill whilst I also agree that adding functionality to the block navigator wouldn't be a bad thing, I do think that reducing to just one instance can be done earlier and the two things aren't connected. Right now, having 2 places is a little confusing, so iterating that could help.

@karmatosed
Copy link
Member Author

Just updating this with some iterations that have gone on outside this issue. There is a consideration to have the block navigator become the primary interface for sub-navigation. If this happens, I would suggest that the toolbar block navigator should be removed, just keeping the sidebar one.

@ZebulanStanphill
Copy link
Member

@karmatosed A primary interface shouldn't go into the inspector, which is for secondary controls.

@karmatosed
Copy link
Member Author

@ZebulanStanphill my comment was about it being used for the sub-navigation adding #21727 has more information.

@ZebulanStanphill
Copy link
Member

@karmatosed Oh, I guess I misunderstood your post. You're suggesting that the interface in #21727 would replace the Block Navigation UI currently present in the toolbar, right? That makes sense.

@karmatosed
Copy link
Member Author

Yes, that's idea @ZebulanStanphill.

@MichaelArestad
Copy link
Contributor

I propose we remove the navigator in the sidebar for a few reasons:

  • It isn't adding any block-specific functionality.
  • It can be a source of confusion when actually trying to use it.
  • There is already a block navigator at the top that does the job pretty well.

@noisysocks noisysocks removed the [Priority] High Used to indicate top priority items that need quick attention label May 20, 2020
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label May 27, 2020
@karmatosed karmatosed added the Needs Dev Ready for, and needs developer efforts label May 27, 2020
@draganescu draganescu changed the title Navigation block: remove one of the navigator interfaces [ Navigation block ] Remove the block navigator in the sidebar Jun 4, 2020
@talldan
Copy link
Contributor

talldan commented Jun 15, 2020

Closed by #23022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

5 participants