Proxy\Http::__construct(): add input validation #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/proxy-http-add-input-validation
branch
2 times, most recently
from
209292a
to
3dff0aa
Compare
The method already contains input validation, but would not notify the dev-user if no usable input was received. This commit adds an `InvalidArgument` exception for that situation. Includes test. Includes improving the documentation for the `$args` parameter. Includes removing a redundant `@since` tag.
jrfnl
force-pushed
the
feature/proxy-http-add-input-validation
branch
from
3dff0aa
to
ad9a9a1
Compare
schlessera
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method already contains input validation, but would not notify the dev-user if no usable input was received.
This commit adds an
InvalidArgumentexception for that situation.Includes test.
Includes improving the documentation for the
$argsparameter.Regarding the other
publicmethods:register()method already have a class based type declaration.curl_before_send(),fsockopen_remote_socket(),fsockopen_remote_host_path()andfsockopen_header()methods are intended to be only called as a Hook callback.publicmethods do not take parameters.