Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input validation #593

Closed
28 tasks done
jrfnl opened this issue Nov 6, 2021 · 1 comment
Closed
28 tasks done

Add input validation #593

jrfnl opened this issue Nov 6, 2021 · 1 comment

Comments

@jrfnl
Copy link
Member

jrfnl commented Nov 6, 2021

This is just an issue to track which classes have been reviewed for missing input validation and the associated PRs adding the input validation.

Input validation is being added to all entry point methods for each class with an InvalidArgument exception being thrown for invalid parameter types. As this may break existing uses of Requests, this input validation needs to be added in the 2.0.0 release.

Action list

Note: the Requests native Exception classes are already exceptions, so rather than throwing another exception on invalid input, these should defer to sensible default values when invalid input is passed.

@jrfnl
Copy link
Member Author

jrfnl commented Nov 16, 2021

Closing as all related PRs have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant