Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality #186

Merged
merged 29 commits into from
Oct 15, 2015
Merged

Improve code quality #186

merged 29 commits into from
Oct 15, 2015

Commits on Oct 14, 2015

  1. Unify redirect check in parse_response and Response 

    Changed the test to expect exceptions for 304, 305, and 306, as these
aren't actually redirects. Previously, these were treated as redirects
by Response, but not by parse_response.
    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    3bb0f48 View commit details
    Browse the repository at this point in the history

  2. Allow passing null as $data

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    3bdec14 View commit details
    Browse the repository at this point in the history

  3. Improve usage of $options['type']

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    140f8f3 View commit details
    Browse the repository at this point in the history

  4. Fix documentation for parse_multiple

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    ade1b0c View commit details
    Browse the repository at this point in the history

  5. Shorten line length in parse_multiple

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    321305f View commit details
    Browse the repository at this point in the history

  6. Add corresponding exception classes for 304, 305, 306

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    b29d69e View commit details
    Browse the repository at this point in the history

  7. Remove unused variable

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    1ba010e View commit details
    Browse the repository at this point in the history

  8. Improve more code quality 

    Woo!
    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    e2dd4b4 View commit details
    Browse the repository at this point in the history

  9. Check that the URL can be parsed before use

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    544a1a9 View commit details
    Browse the repository at this point in the history

  10. Send $out to fsockopen.after_send, not an unused variable

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    b96e9db View commit details
    Browse the repository at this point in the history

  11. Improve quality for Requests_Cookie

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    faa0fbe View commit details
    Browse the repository at this point in the history

  12. Change $fp to $socket for clarity

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    890d510 View commit details
    Browse the repository at this point in the history

  13. Pass no parameters to curl.after_send

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    aa3cdcb View commit details
    Browse the repository at this point in the history

  14. Improve code quality of IDNAEncoder

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    e614232 View commit details
    Browse the repository at this point in the history

  15. Bring IPv6 class in line with standards

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    68337c0 View commit details
    Browse the repository at this point in the history

  16. Bring IRI class in line with standards

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    684de09 View commit details
    Browse the repository at this point in the history

  17. Remove die from Requests_IRI

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    6d7b7d7 View commit details
    Browse the repository at this point in the history

  18. Simplify IPv6::uncompress

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    e12a2b1 View commit details
    Browse the repository at this point in the history

  19. Use sprintf instead of concatenation

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    216e678 View commit details
    Browse the repository at this point in the history

  20. Use new parse_from_headers

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    4825828 View commit details
    Browse the repository at this point in the history

  21. Correct documentation for Response

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    77ea59e View commit details
    Browse the repository at this point in the history

  22. Add missing braces

    @rmccue
    rmccue committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    0fbed0f View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2015

  1. Clean up code per coding standards

    @rmccue
    rmccue committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    3626938 View commit details
    Browse the repository at this point in the history

  2. Document available properties on IRI

    @rmccue
    rmccue committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    063384b View commit details
    Browse the repository at this point in the history

  3. Clarify i* vs * properties in IRI

    @rmccue
    rmccue committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    6a81795 View commit details
    Browse the repository at this point in the history

  4. Clarify we're allowed null for $data

    @rmccue
    rmccue committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    49ee946 View commit details
    Browse the repository at this point in the history

  5. Remove TODO

    @rmccue
    rmccue committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    e436a4a View commit details
    Browse the repository at this point in the history

  6. Fix inline docs in Cookie

    @rmccue
    rmccue committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    10a93a0 View commit details
    Browse the repository at this point in the history

  7. Fix more documentation and quality ✨

    @rmccue
    rmccue committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    04e4167 View commit details
    Browse the repository at this point in the history