Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality #186

Merged
merged 29 commits into from
Oct 15, 2015
Merged

Improve code quality #186

merged 29 commits into from
Oct 15, 2015

Conversation

rmccue
Copy link
Collaborator

@rmccue rmccue commented Oct 14, 2015

Let's improve quality based on Scrutinizer reports.

@rmccue
Unify redirect check in parse_response and Response
3bb0f48 
Changed the test to expect exceptions for 304, 305, and 306, as these
aren't actually redirects. Previously, these were treated as redirects
by Response, but not by parse_response.
@rmccue
Allow passing null as $data
3bdec14
@rmccue
Improve usage of $options['type']
140f8f3
@rmccue
Fix documentation for parse_multiple
ade1b0c
@rmccue
Shorten line length in parse_multiple
321305f
@rmccue
Add corresponding exception classes for 304, 305, 306
b29d69e
@rmccue
Remove unused variable
1ba010e
@rmccue
Improve more code quality
e2dd4b4 
Woo!
@rmccue
Check that the URL can be parsed before use
544a1a9
@rmccue
Send $out to fsockopen.after_send, not an unused variable
b96e9db
@rmccue
Improve quality for Requests_Cookie
faa0fbe
@rmccue
Change $fp to $socket for clarity
890d510
@rmccue
Pass no parameters to curl.after_send
aa3cdcb
@rmccue
Improve code quality of IDNAEncoder
e614232
@rmccue
Bring IPv6 class in line with standards
68337c0
@rmccue
Bring IRI class in line with standards
684de09
@rmccue
Remove die from Requests_IRI
6d7b7d7
@rmccue rmccue added this to the 1.7 milestone Oct 14, 2015
rmccue added a commit that referenced this pull request Oct 15, 2015
@rmccue
Merge pull request #186 from rmccue/improve-code-quality
8c3bbbb 
Improve code quality
@rmccue rmccue merged commit 8c3bbbb into master Oct 15, 2015
@rmccue rmccue deleted the improve-code-quality branch October 15, 2015 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
1 participant
@rmccue