Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use SAID for long running operation oid instead of identifier prefix #289

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

iFergal
Copy link
Contributor

@iFergal iFergal commented Sep 2, 2024

To address #285.

I initially required this for exn messages but decided to apply it everywhere because otherwise I think we may run into other edge case issues.

Signify-TS integration tests all pass with minor adjustment.

src/keria/app/delegating.py Show resolved Hide resolved
src/keria/app/ipexing.py Show resolved Hide resolved
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 97.85714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.68%. Comparing base (18d3ad7) to head (9df840d).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/keria/core/longrunning.py 90.32% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   93.06%   93.68%   +0.62%     
==========================================
  Files          36       36              
  Lines        7121     7859     +738     
==========================================
+ Hits         6627     7363     +736     
- Misses        494      496       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iFergal
Copy link
Contributor Author

iFergal commented Sep 2, 2024

will improve coverage later/tomorrow but otherwise ready for review impl wise

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/keria/app/delegating.py Show resolved Hide resolved
Copy link
Contributor

@rodolfomiranda rodolfomiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

… make sense given the impl in longrunning.py)
@iFergal
Copy link
Contributor Author

iFergal commented Sep 3, 2024

@rodolfomiranda @2byrds The oid I had for OpTypes.submit didn't make sense. The name always matched the identifier and the code shouldn't be there (related to 2FA).

I've reverted that section because longrunning.py simply checks if the submits have finished completing for all things related to that agent, rather than specifically for the identifier. So that probably needs some more attention itself in another PR

@2byrds 2byrds merged commit 529b468 into WebOfTrust:main Sep 3, 2024
5 checks passed
@iFergal iFergal deleted the feat/longRunningSaidOid branch September 3, 2024 19:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants