Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange message operations should use a different oid #285

Closed
iFergal opened this issue Aug 27, 2024 · 4 comments
Closed

Exchange message operations should use a different oid #285

iFergal opened this issue Aug 27, 2024 · 4 comments

Comments

@iFergal
Copy link
Collaborator

iFergal commented Aug 27, 2024

Almost everywhere in KERIA we create long running operations with an oid value of the related identifier.

The problem with doing this for exchange messages (maybe other scenarios too?) is you cannot have multiple long running operations for exn messages at the same time. And that's very probable for multi-sig when the operation does not complete until at minimum a threshold amount of signers have signed.

Easiest solution might be to use the SAID of the exn message (or maybe the embedded exn in the case of multisig) instead of embedding it in the metadata of the op.

Are there any concerns with this?


Here is an example test: cardano-foundation/signify-ts@9b641cd

  • 2 of 2 multi-sig
  • 2 credentials issued
  • Member1 admits both, member2 admits none (so neither admit has completed)
  • The first long running operation has been replaced by the second (metadata updated)
@2byrds
Copy link
Collaborator

2byrds commented Aug 28, 2024

Almost everywhere in KERIA we create long running operations with an oid value of the related identifier.

The problem with doing this for exchange messages (maybe other scenarios too?) is you cannot have multiple long running operations for exn messages at the same time. And that's very probable for multi-sig when the operation does not complete until at minimum a threshold amount of signers have signed.

Easiest solution might be to use the SAID of the exn message (or maybe the embedded exn in the case of multisig) instead of embedding it in the metadata of the op.

Are there any concerns with this?

Here is an example test: cardano-foundation/signify-ts@9b641cd

  • 2 of 2 multi-sig
  • 2 credentials issued
  • Member1 admits both, member2 admits none (so neither admit has completed)
  • The first long running operation has been replaced by the second (metadata updated)

exn (and embedded exn) SAID seems like an improvement to me @iFergal

@iFergal
Copy link
Collaborator Author

iFergal commented Aug 30, 2024

In the case of IPEX, the operation is actually for the embedded exn anyway so SAID makes sense. I have started working on this locally, will continue... I think it actually makes sense to do this everywhere, and not just exn.

For example, you could issue 2 rotations in a row for an identifier - second replaces the first. But maybe the second fails due to a bug in Signify-TS. Now you can't track the first rotation which successfully completes.

@SmithSamuelM
Copy link
Contributor

Using the SAID for exn transaction id presages the keri version 2 optional exn format which adds an exn inception event to exn transactions so that a set of exns chained off from their inception can be tracked by the said of the inception event.

@iFergal
Copy link
Collaborator Author

iFergal commented Sep 4, 2024

Completed with #289

@iFergal iFergal closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants