-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exchange message operations should use a different oid #285
Comments
exn (and embedded exn) SAID seems like an improvement to me @iFergal |
In the case of IPEX, the operation is actually for the embedded exn anyway so SAID makes sense. I have started working on this locally, will continue... I think it actually makes sense to do this everywhere, and not just exn. For example, you could issue 2 rotations in a row for an identifier - second replaces the first. But maybe the second fails due to a bug in Signify-TS. Now you can't track the first rotation which successfully completes. |
Using the SAID for exn transaction id presages the keri version 2 optional exn format which adds an exn inception event to exn transactions so that a set of exns chained off from their inception can be tracked by the said of the inception event. |
Completed with #289 |
Almost everywhere in KERIA we create long running operations with an
oid
value of the related identifier.The problem with doing this for exchange messages (maybe other scenarios too?) is you cannot have multiple long running operations for exn messages at the same time. And that's very probable for multi-sig when the operation does not complete until at minimum a threshold amount of signers have signed.
Easiest solution might be to use the SAID of the exn message (or maybe the embedded exn in the case of multisig) instead of embedding it in the metadata of the op.
Are there any concerns with this?
Here is an example test: cardano-foundation/signify-ts@9b641cd
The text was updated successfully, but these errors were encountered: