feat: multi-sig IPEX apply, offer, agree endpoints #278
Conversation
| @@ -144,6 +143,8 @@ def sendMultisigExn(agent, hab, ked, sigs, atc, rec): | |||
| if grant is None: | |||
| raise falcon.HTTPBadRequest(description=f"attempt to admit an invalid grant {admitked['p']}") | |||
|
|
|||
| agent.exchanges.append(dict(said=serder.said, pre=hab.pre, rec=rec, topic='credential')) | |||
There was a problem hiding this comment.
I've moved this below the above checks for the exn message and link to grant etc - presume we don't want to send the /multisig/exn message to others until we have passed those checks
| @@ -341,24 +363,32 @@ def test_ipex_grant(helpers, mockHelpingNowIso8601, seeder): | |||
| 'title': '400 Bad Request'} | |||
|
|
|||
|
|
|||
| def test_multisig_grant_admit(seeder, helpers): | |||
| def test_multisig(seeder, helpers): | |||
There was a problem hiding this comment.
This test is now even longer, so not sure. But the setup of multi-sigs and credentials being issued is expensive so decided to keep it all to one test if that's OK.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 93.06% 93.11% +0.04%
==========================================
Files 36 36
Lines 7121 7562 +441
==========================================
+ Hits 6627 7041 +414
- Misses 494 521 +27 ☔ View full report in Codecov by Sentry. |
|
Note - multi-sig admit should retrieve the recipient of admit from the Will update that after Signify-TS has been updated though to always pass the recipient. |
Continuing #193 for multi-sig. No spurn yet.