Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPEX apply, offer, agree implementation #193

Closed
iFergal opened this issue Feb 13, 2024 · 2 comments
Closed

IPEX apply, offer, agree implementation #193

iFergal opened this issue Feb 13, 2024 · 2 comments
Assignees

Comments

@iFergal
Copy link
Collaborator

iFergal commented Feb 13, 2024

I would like to get these added to KERIA and Signify-TS as it's something my team needs. Happy to give it a try myself, perhaps apply -> offer -> agree for a normal AID to begin with (multisig, spurn later).

Understanding the existing impl:
I've taken a look at the existing grant and apply messages in KERIA. The messages are parsed, pushed onto the exchanging deck to be sent to recipients and then pushed to either the grants or admits deck in agent.ts. From what I understand: Granter will send the other necessary material such as registry events, and Admitter will parse the ACDC, issuance and anchoring events attached to the admit message.

Q: Admitter will actually first check to see if there's a grant listed (otherwise invalid) - in case the grant is missing, or there is an issue parsing the attachments (e.g. the ACDC itself) hasn't the admit message already been sent to other parties using exchanging in ipexing.py? Curious if we should should check the grant is listed before sending the message onwards.

New messages:
apply and agree messages seem straight forward - do I need to do anything more other than sending the message to recipients in KERIA?

For offer I need a metadata ACDC, not sure if there's anything already available for this. Looking at the IPEX tests in keripy, it seems to just use a normal ACDC. Though it shouldn't be too hard to strip it down to a metadata ACDC and re-calculate the SAID.

@iFergal
Copy link
Collaborator Author

iFergal commented Feb 21, 2024

@pfeairheller Have some questions re Admitter flow and the metadata ACDC in the description above if you have time to answer. Thanks :)

Just going to start looking at this today/this week - have been stuck on other things.

@lenkan
Copy link
Collaborator

lenkan commented Aug 27, 2024

@iFergal can this be closed now?

@iFergal iFergal closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants