[Auth, Sign] #485 remove pairing #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llbartekll
changed the title
flypaper0
reviewed
Sep 5, 2022
| import WalletConnectUtils | ||
| import WalletConnectPairing | ||
|
|
||
| class DeletePairingService { |
There was a problem hiding this comment.
Can we move it in WalletConnectPairing package?
There was a problem hiding this comment.
oh, I see. Whey using different NetworkInteractors..
There was a problem hiding this comment.
yeah exactly, even the protocol method is the same
flypaper0
reviewed
Sep 5, 2022
| if pairingStorage.hasPairing(forTopic: topic) { | ||
| try await deletePairingService.delete(topic: topic) | ||
| } else if sessionStorage.hasSession(forTopic: topic) { | ||
| try await deleteSessionService.delete(topic: topic) |
There was a problem hiding this comment.
Pairing and a session at the same time? I mean: do we need to clear pairing and session together on disconnect call?
There was a problem hiding this comment.
if so, I think is better to have 1 DeleteSessionService, which clean pairing and session storage
There was a problem hiding this comment.
one topic corresponds to one pairing or one session and we have a common public method for deletion.
So we either delete a pairing or a session.
flypaper0
approved these changes
Sep 5, 2022
…V2 into #447-remove-pairing # Conflicts: # Package.swift # Sources/Auth/Services/Common/NetworkingInteractor.swift # Sources/Chat/ChatClient.swift # Sources/Chat/ChatClientFactory.swift # Sources/Chat/ProtocolServices/Common/MessagingService.swift # Sources/Chat/ProtocolServices/Invitee/InvitationHandlingService.swift # Sources/Chat/ProtocolServices/Inviter/InviteService.swift # Sources/Chat/Types/Message.swift # Sources/WalletConnectNetworking/NetworkInteractor.swift # Sources/WalletConnectNetworking/NetworkingInteractor.swift # Sources/WalletConnectNetworking/RequestSubscriptionPayload.swift # Sources/WalletConnectNetworking/ResponseSubscriptionPayload.swift # Tests/TestingUtils/NetworkingInteractorMock.swift
flypaper0
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #485 #447
How Has This Been Tested?
Due Dilligence