Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sign] Allow to remove pairing #447

Closed
llbartekll opened this issue Aug 18, 2022 · 0 comments
Closed

[Sign] Allow to remove pairing #447

llbartekll opened this issue Aug 18, 2022 · 0 comments
Assignees
@llbartekll
Labels
accepted enhancement New feature or request

Comments

@llbartekll
Copy link
Contributor

Update disconnect method to follow the specs:

  // for either to disconnect a session or pairing
  public abstract disconnect(params: {
    topic: string;
    reason: Reason;
  }): Promise<void>;
@llbartekll llbartekll added the enhancement New feature or request label Aug 18, 2022
@llbartekll llbartekll added this to the v2.0-rc.1 milestone Aug 18, 2022
@llbartekll llbartekll moved this to Todo in Swift SDK Aug 18, 2022
@arein arein added the accepted label Aug 18, 2022
@llbartekll llbartekll mentioned this issue Aug 18, 2022
Closed
@llbartekll llbartekll moved this from Todo to Accepted in Swift SDK Aug 18, 2022
@llbartekll llbartekll self-assigned this Aug 29, 2022
@llbartekll llbartekll moved this from Accepted to In Progress in Swift SDK Sep 2, 2022
@llbartekll llbartekll mentioned this issue Sep 5, 2022
Merged
2 tasks
@llbartekll llbartekll moved this from In Progress to In Review in Swift SDK Sep 5, 2022
llbartekll added a commit that referenced this issue Sep 5, 2022
@llbartekll
Merge branch 'develop' of github.com:WalletConnect/WalletConnectSwift…
2442dca 
…V2 into #447-remove-pairing

# Conflicts:
#	Package.swift
#	Sources/Auth/Services/Common/NetworkingInteractor.swift
#	Sources/Chat/ChatClient.swift
#	Sources/Chat/ChatClientFactory.swift
#	Sources/Chat/ProtocolServices/Common/MessagingService.swift
#	Sources/Chat/ProtocolServices/Invitee/InvitationHandlingService.swift
#	Sources/Chat/ProtocolServices/Inviter/InviteService.swift
#	Sources/Chat/Types/Message.swift
#	Sources/WalletConnectNetworking/NetworkInteractor.swift
#	Sources/WalletConnectNetworking/NetworkingInteractor.swift
#	Sources/WalletConnectNetworking/RequestSubscriptionPayload.swift
#	Sources/WalletConnectNetworking/ResponseSubscriptionPayload.swift
#	Tests/TestingUtils/NetworkingInteractorMock.swift
llbartekll added a commit that referenced this issue Sep 5, 2022
@llbartekll
Merge pull request #486 from WalletConnect/#447-remove-pairing
918c8e1 
[Auth, Sign] #485 remove pairing
@llbartekll llbartekll moved this from In Review to Done in Swift SDK Sep 6, 2022
@llbartekll llbartekll moved this from Done to Accepted in Swift SDK Sep 8, 2022
Repository owner moved this from Accepted to Done in Swift SDK Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llbartekll llbartekll

Labels
accepted enhancement New feature or request
Projects
Swift SDK
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arein @llbartekll