-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auth] #377 Auth respond service #401
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b6b8632
manage keys for response
llbartekll e6f44d6
update AuthRespondService, extend RPCResponse
llbartekll 39238f0
Update Auth respond service
llbartekll 4157195
Merge branch 'develop' of github.com:WalletConnect/WalletConnectSwift…
llbartekll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import Foundation | ||
|
||
protocol CacaoFormatting { | ||
func format(_ request: AuthRequestParams, _ signature: CacaoSignature, _ issuer: Account) -> Cacao | ||
} | ||
|
||
class CacaoFormatter: CacaoFormatting { | ||
func format(_ request: AuthRequestParams, _ signature: CacaoSignature, _ issuer: Account) -> Cacao { | ||
fatalError("not implemented") | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,41 @@ | ||
import Foundation | ||
import WalletConnectKMS | ||
import JSONRPC | ||
import WalletConnectUtils | ||
|
||
actor AuthRespondService { | ||
enum Errors: Error { | ||
case recordForIdNotFound | ||
case malformedAuthRequestParams | ||
} | ||
private let networkingInteractor: NetworkInteracting | ||
private let kms: KeyManagementService | ||
private let rpcHistory: RPCHistory | ||
private let logger: ConsoleLogging | ||
|
||
init(networkingInteractor: NetworkInteracting) { | ||
init(networkingInteractor: NetworkInteracting, | ||
logger: ConsoleLogging, | ||
kms: KeyManagementService, | ||
rpcHistory: RPCHistory) { | ||
self.networkingInteractor = networkingInteractor | ||
self.logger = logger | ||
self.kms = kms | ||
self.rpcHistory = rpcHistory | ||
} | ||
|
||
func respond(respondParams: RespondParams) async throws { | ||
func respond(respondParams: RespondParams, issuer: Account) async throws { | ||
guard let request = rpcHistory.get(recordId: RPCID(respondParams.id))?.request else { throw Errors.recordForIdNotFound } | ||
guard let authRequestParams = try? request.params?.get(AuthRequestParams.self) else { throw Errors.malformedAuthRequestParams } | ||
|
||
let peerPubKey = authRequestParams.requester.publicKey | ||
let responseTopic = peerPubKey.rawRepresentation.sha256().toHexString() | ||
let selfPubKey = try kms.createX25519KeyPair() | ||
let agreementKeys = try kms.performKeyAgreement(selfPublicKey: selfPubKey, peerPublicKey: peerPubKey) | ||
try kms.setAgreementSecret(agreementKeys, topic: responseTopic) | ||
|
||
let cacao = CacaoFormatter().format(authRequestParams, respondParams.signature, issuer) | ||
let response = RPCResponse(id: request.id!, result: cacao) | ||
|
||
try await networkingInteractor.respond(topic: respondParams.topic, response: response, tag: AuthResponseParams.tag, envelopeType: .type1(pubKey: selfPubKey.rawRepresentation)) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import Foundation | ||
|
||
struct Cacao: Codable, Equatable { | ||
let header: CacaoHeader | ||
let payload: CacaoPayload | ||
let signature: CacaoSignature | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
import Foundation | ||
import WalletConnectUtils | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
import Foundation | ||
import WalletConnectUtils | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
import Foundation | ||
|
||
struct RespondParams { | ||
let id: Int64 | ||
let topic: String | ||
let signature: CacaoSignature | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,26 @@ | ||
import Foundation | ||
import Combine | ||
@testable import Auth | ||
import JSONRPC | ||
import WalletConnectKMS | ||
|
||
struct NetworkingInteractorMock: NetworkInteracting { | ||
|
||
let requestPublisherSubject = PassthroughSubject<RequestSubscriptionPayload, Never>() | ||
var requestPublisher: AnyPublisher<RequestSubscriptionPayload, Never> { | ||
requestPublisherSubject.eraseToAnyPublisher() | ||
} | ||
|
||
func subscribe(topic: String) async throws { | ||
|
||
|
||
} | ||
|
||
func request(_ request: RPCRequest, topic: String, tag: Int, envelopeType: Envelope.EnvelopeType) async throws { | ||
|
||
} | ||
|
||
func respond(topic: String, response: RPCResponse, tag: Int, envelopeType: Envelope.EnvelopeType) async throws { | ||
|
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,4 +7,3 @@ class SIWEMessageFormatterMock: SIWEMessageFormatting { | |
return formattedMessage | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you needed an init that receives a
RPCID
. In your opinion, do you think it's better to add these specific inits or should we change the default init frominternal
topublic
?