Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore integration tests #250

Closed
sekimondre opened this issue May 30, 2022 · 1 comment · Fixed by #500
Closed

Restore integration tests #250

sekimondre opened this issue May 30, 2022 · 1 comment · Fixed by #500
Assignees
@llbartekll
Milestone
v2.0-rc.0

Comments

@sekimondre
Copy link

No description provided.

@sekimondre sekimondre self-assigned this May 30, 2022
@chadyj chadyj added this to the v2.0-beta.101 milestone Jun 9, 2022
@chadyj chadyj moved this from Todo to In Progress in Swift SDK Jun 9, 2022
@chadyj chadyj modified the milestones: v2.0-beta.101, v2.0-beta.102 Jun 10, 2022
sekimondre pushed a commit that referenced this issue Jun 14, 2022
#250 Integration Tests: Re-enable session propose-approve test case (#…
e3881c5 
…268)

* Enabled session approve test, failing

* Workaround fix test

* Refactor working session approve test

* Renamed test to SignClientTests

* Removed controller flag from tests

Co-authored-by: André Vants
sekimondre pushed a commit that referenced this issue Jun 14, 2022
[Test] #250: Re-enable session reject integration test case (#269)
2b8072a 
Re-enable session rejection test

Co-authored-by: André Vants
@flypaper0 flypaper0 mentioned this issue Jul 5, 2022
Merged
llbartekll pushed a commit that referenced this issue Jul 5, 2022
@llbartekll
#250 Integration Tests: Re-enable session propose-approve test case (#…
4b5f6dc 
…268)

* Enabled session approve test, failing

* Workaround fix test

* Refactor working session approve test

* Renamed test to SignClientTests

* Removed controller flag from tests

Co-authored-by: André Vants
llbartekll pushed a commit that referenced this issue Jul 5, 2022
@llbartekll
[Test] #250: Re-enable session reject integration test case (#269)
c6d2c84 
Re-enable session rejection test

Co-authored-by: André Vants
llbartekll added a commit that referenced this issue Jul 7, 2022
@llbartekll
Merge pull request #314 from WalletConnect/test/#250-ping-integration…
e048eb4 
…-test

[Tests] Bugfix: #250: Re-enable ping integration test
llbartekll added a commit that referenced this issue Jul 8, 2022
@llbartekll
Merge pull request #318 from WalletConnect/tests/#250-delete-integrat…
a454d06 
…ion-test

[Tests] #250: Re-enable session delete integration test
@chadyj chadyj modified the milestones: v2.0-beta.102, v2.0-rc.1 Jul 13, 2022
@flypaper0
Copy link
Contributor

flypaper0 commented Jul 13, 2022 •
edited
Loading

@MisterVants We have some disabled tests in Sign SDK.
Also need to find way how to run testAcceptAndCreateNewThread() and testMessage() on CI machine. They passes on xcode 13.4 only, CI runs on 13.2 now

@flypaper0 flypaper0 mentioned this issue Jul 19, 2022
Merged
sekimondre pushed a commit that referenced this issue Aug 4, 2022
Merge pull request #398 from WalletConnect/tests/#250-request-integra…
203255e 
…tion-test

[Tests] #250 Session Request integration tests re-enabled
@llbartekll llbartekll moved this from In Progress to Accepted in Swift SDK Aug 29, 2022
@llbartekll llbartekll self-assigned this Sep 9, 2022
@llbartekll llbartekll moved this from Accepted to In Progress in Swift SDK Sep 9, 2022
@llbartekll llbartekll mentioned this issue Sep 12, 2022
Merged
2 tasks
@llbartekll llbartekll moved this from In Progress to In Review in Swift SDK Sep 12, 2022
flypaper0 added a commit that referenced this issue Sep 12, 2022
@flypaper0
Merge pull request #500 from WalletConnect/#250-Sign-restore-integrat…
b10c626 
…ion-tests

#250 sign restore integration tests
@llbartekll llbartekll moved this from In Review to Done in Swift SDK Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llbartekll llbartekll

Labels
None yet
Projects
Swift SDK
Archived in project
Milestone
v2.0-rc.0
Development

Successfully merging a pull request may close this issue.

#250 sign restore integration tests WalletConnect/WalletConnectSwiftV2
4 participants
@chadyj @flypaper0 @sekimondre @llbartekll