[Test] #250: Re-enable session reject integration test case (#269)

Re-enable session rejection test Co-authored-by: André Vants
WalletConnect · Jul 5, 2022 · c6d2c84 · c6d2c84
1 parent 4b5f6dc
commit c6d2c84
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 17 deletions.
diff --git a/Sources/WalletConnectSign/Session.swift b/Sources/WalletConnectSign/Session.swift
@@ -16,7 +16,7 @@ public struct Session {
 
 extension Session {
 
-    public struct Proposal {
+    public struct Proposal: Equatable {
         public var id: String
         public let proposer: AppMetadata
         public let requiredNamespaces: [String: ProposalNamespace]

diff --git a/Tests/IntegrationTests/SignClientTests.swift b/Tests/IntegrationTests/SignClientTests.swift
@@ -76,6 +76,28 @@ final class SignClientTests: XCTestCase {
         try await wallet.client.pair(uri: uri!)
         wait(for: [dappSettlementExpectation, walletSettlementExpectation], timeout: defaultTimeout)
     }
+
+    func testSessionReject() async throws {
+        let dapp = proposer!
+        let wallet = responder!
+        let sessionRejectExpectation = expectation(description: "Proposer is notified on session rejection")
+        var rejectedProposal: Session.Proposal?
+
+        let uri = try await dapp.client.connect(requiredNamespaces: ProposalNamespace.stubRequired())
+        try await wallet.client.pair(uri: uri!)
+
+        wallet.onSessionProposal = { proposal in
+            do {
+                try wallet.client.reject(proposalId: proposal.id, reason: .disapprovedChains) // TODO: Review reason
+                rejectedProposal = proposal
+            } catch { XCTFail("\(error)") }
+        }
+        dapp.onSessionRejected = { proposal, _ in
+            XCTAssertEqual(rejectedProposal, proposal)
+            sessionRejectExpectation.fulfill() // TODO: Assert reason code
+        }
+        wait(for: [sessionRejectExpectation], timeout: defaultTimeout)
+    }
 //
 //    func testNewPairingPing() async {
 //        let responderReceivesPingResponseExpectation = expectation(description: "Responder receives ping response")
@@ -123,22 +145,6 @@ final class SignClientTests: XCTestCase {
 //        wait(for: [proposerSettlesSessionExpectation, responderSettlesSessionExpectation], timeout: defaultTimeout)
 //    }
 //
-//    func testResponderRejectsSession() async {
-//        await waitClientsConnected()
-//        let sessionRejectExpectation = expectation(description: "Proposer is notified on session rejection")
-//        let uri = try! await proposer.client.connect(namespaces: [Namespace.stub()])!
-//        _ = try! await responder.client.pair(uri: uri)
-//
-//        responder.onSessionProposal = {[unowned self] proposal in
-//            self.responder.client.reject(proposal: proposal, reason: .disapprovedChains)
-//        }
-//        proposer.onSessionRejected = { _, reason in
-//            XCTAssertEqual(reason.code, 5000)
-//            sessionRejectExpectation.fulfill()
-//        }
-//        wait(for: [sessionRejectExpectation], timeout: defaultTimeout)
-//    }
-//
 //    func testDeleteSession() async {
 //        await waitClientsConnected()
 //        let sessionDeleteExpectation = expectation(description: "Responder is notified on session deletion")