-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: web monetization welcome screen #462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
huijing marked as non substantive for IPR from ash-nazg. |
984f499
to
e1164f6
Compare
sidvishnoi
reviewed
Jul 23, 2024
sidvishnoi
reviewed
Jul 23, 2024
sidvishnoi
reviewed
Jul 23, 2024
sidvishnoi
reviewed
Jul 23, 2024
huijing
reviewed
Jul 30, 2024
huijing
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with all the success param options. LGTM. Just a minor non-blocking suggestion on the size of the icon.
sidvishnoi
reviewed
Jul 30, 2024
sidvishnoi
reviewed
Jul 30, 2024
sidvishnoi
reviewed
Jul 30, 2024
sidvishnoi
approved these changes
Jul 30, 2024
sidvishnoi
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #461.
This PR introduces the welcome screen that will display meaningful error messages if an error occurs when users attempt to connect their wallet to the extension (if needed) or a success message which means that everything went well and their wallet is now connected to the extension.