Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: web monetization welcome screen #462

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Conversation

raducristianpopa
Copy link
Collaborator

Closes #461.

This PR introduces the welcome screen that will display meaningful error messages if an error occurs when users attempt to connect their wallet to the extension (if needed) or a success message which means that everything went well and their wallet is now connected to the extension.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for webmonetization-preview ready!

Name Link
🔨 Latest commit 36f0358
🔍 Latest deploy log https://app.netlify.com/sites/webmonetization-preview/deploys/66a8bdc58d70880008002dc8
😎 Deploy Preview https://deploy-preview-462--webmonetization-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@w3cbot
Copy link

w3cbot commented Jul 22, 2024

huijing marked as non substantive for IPR from ash-nazg.

@raducristianpopa raducristianpopa marked this pull request as ready for review July 23, 2024 08:24
@raducristianpopa raducristianpopa requested a review from huijing July 23, 2024 08:24
src/pages/welcome.astro Outdated Show resolved Hide resolved
src/pages/welcome.astro Outdated Show resolved Hide resolved
src/pages/welcome.astro Outdated Show resolved Hide resolved
src/pages/welcome.astro Outdated Show resolved Hide resolved
@raducristianpopa raducristianpopa marked this pull request as draft July 24, 2024 14:02
@raducristianpopa raducristianpopa marked this pull request as ready for review July 26, 2024 10:16
src/pages/welcome.astro Outdated Show resolved Hide resolved
Copy link
Collaborator

@huijing huijing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with all the success param options. LGTM. Just a minor non-blocking suggestion on the size of the icon.

src/pages/welcome.astro Outdated Show resolved Hide resolved
src/pages/welcome.astro Outdated Show resolved Hide resolved
src/pages/welcome.astro Outdated Show resolved Hide resolved
@raducristianpopa raducristianpopa merged commit b658278 into main Jul 30, 2024
6 checks passed
@raducristianpopa raducristianpopa deleted the rp/wm-welcome-page branch July 30, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a page where users can be redirected to after a budget is approved for WM
4 participants