Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style onboarding email #7

Merged
merged 4 commits into from
Oct 13, 2024
Merged

Style onboarding email #7

merged 4 commits into from
Oct 13, 2024

Conversation

ben-z
Copy link
Member

@ben-z ben-z commented Oct 13, 2024

Style changes

This PR adds a logo to the email:

image

Perf changes

Removes the use of tailwind: not using tailwind cuts rendering time by about half (tested in infra-config using time python3 emails/onboarding/get-config.py generate-emails --output-path /tmp/out.json. Time went from 18 seconds to 9 seconds on 64 cores).

Here's the output of perf.sh before and after:

# before
ben@thor-slurm1 ~/Projects/watcloud-emails main ?2 ❯ ./scripts/perf.sh
Generating onboarding 1
Generating onboarding 2
Generating onboarding 3
Generating onboarding 4
Generating onboarding 5
Generating onboarding 6
Generating onboarding 7
Generating onboarding 8
Generating onboarding 9
Generating onboarding 10

real    0m8.250s
user    0m8.533s
sys     0m1.660s


Generating onboarding bulk with size 10

real    0m3.285s
user    0m4.328s
sys     0m0.554s


# after
ben@thor-slurm1 ~/Projects/watcloud-emails benz/onboarding-styles ?2 ❯ ./scripts/perf.sh
Generating onboarding 1
Generating onboarding 2
Generating onboarding 3
Generating onboarding 4
Generating onboarding 5
Generating onboarding 6
Generating onboarding 7
Generating onboarding 8
Generating onboarding 9
Generating onboarding 10

real    0m5.597s
user    0m5.285s
sys     0m1.025s


Generating onboarding bulk with size 10

real    0m0.637s
user    0m0.602s
sys     0m0.147s

We are seeing significant speedup when using the bulk command. The running time increases much slower with size:

Generating onboarding bulk with size 100

real    0m0.854s
user    0m1.099s
sys     0m0.134s

@ben-z ben-z marked this pull request as ready for review October 13, 2024 02:23
@ben-z ben-z merged commit 3472e64 into main Oct 13, 2024
1 check passed
@ben-z ben-z deleted the benz/onboarding-styles branch October 13, 2024 02:24
ben-z added a commit that referenced this pull request Oct 13, 2024
A bug was introduced in #7 where WATcloudURI-based images can't be
loaded in the development environment. This PR fixes this.

Before:
<img width="1392" alt="image"
src="https://github.com/user-attachments/assets/f0833cc8-cfe2-485d-b697-3e2226578de2">


After:

<img width="1392" alt="image"
src="https://github.com/user-attachments/assets/a3082519-e9c3-4a75-91d1-0fbb9b78bea7">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant