Remove [SAVE|RESTORE]_GCODE_STATE from PRINT_END macro #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
You are correct. I'll change the commit text. |
voidtrance
force-pushed
the
for/Voron-2/print-end
branch
from
05091a6
to
2f783ed
Compare
voidtrance
force-pushed
the
for/Voron-2/print-end
branch
from
2f783ed
to
80f2694
Compare
|
I've updated the change to match the one already merged into the Trident repository. |
KiloQubit
requested changes
Nov 9, 2023
…ronDesign#136) The PRINT_END macro in the Octopus config file contains a pair of SAVE_GCODE_STATE/RESTORE_GCODE_STATE command. The purpose of those commands is to allow the macro to perfom actions at the end of the print and then restore the printer state as it was prior to the macro's execution (restore coordinate system and speeds). However, there was some confusion as to the effect of those calls, particularly the RESTORE_GCODE_STATE. What is desired is that the printer state is restored but the toolhead position is not. To clarify the intention and prevent any issues, the "MOVE=0" argument to RESTORE_GCODE_STATE is added as to explicitly prevent any toolhead position changes and a comment is added to describe the purpose of the commands. Since having the commands in the PRINT_END macro is something that is needed, the same commands have also been added to any of the other configs which were missing it.
voidtrance
force-pushed
the
for/Voron-2/print-end
branch
from
80f2694
to
f58ee6b
Compare
KiloQubit
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample configuration for some boards contain PRINT_END macros that include [SAVE|RESTORE]_GCODE_STATE command in them.
Unfortunately, those commands may have a negative effect in that the macro tries to perform some safety moves between them to move the toolhead away from the print. However, when the GCode state is restore, Klipper will move the toolhead to the last position before the GCode state is save. This will negate the safety moves and put the toolhead back where it was.
Fix this by removing the [SAVE|RESTORE]_GCODE_STATE command.