Skip to content

Update random token generation as suggested #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VishalX merged 1 commit into from
May 21, 2026
Merged

Update random token generation as suggested #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions benchmark/c/options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,19 +100,6 @@ void VerifyOptions(const Options& opts) {
throw std::runtime_error("ONNX model directory path must be provided.");
}

const int prompt_source_count = opts.prompt_length_specified + opts.prompt_specified + opts.prompt_file_specified;
if (prompt_source_count > 1) {
throw std::runtime_error("--prompt_length, --prompt, and --prompt_file are mutually exclusive.");
}

if (opts.use_random_tokens && !opts.prompt_length_specified) {
throw std::runtime_error("--use_random_tokens requires -l/--prompt_length.");
}

if (opts.use_random_tokens && (opts.prompt_specified || opts.prompt_file_specified)) {
throw std::runtime_error("--use_random_tokens cannot be used with --prompt or --prompt_file.");
}

// validate execution provider since it has a valid value
ValidateExecutionProvider(opts.execution_provider);
}
Expand Down Expand Up @@ -143,14 +130,17 @@ Options ParseOptionsFromCommandLine(int argc, const char* const* argv) {
} else if (arg == "-b" || arg == "--batch_size") {
opts.batch_size = ParseNumber<size_t>(next_arg(i));
} else if (arg == "-l" || arg == "--prompt_length") {
if (prompt_num_tokens_or_content.has_value())
throw std::runtime_error("--prompt_length, --prompt, and --prompt_file are mutually exclusive.");
prompt_num_tokens_or_content = ParseNumber<size_t>(next_arg(i));
opts.prompt_length_specified = true;
} else if (arg == "--prompt") {
if (prompt_num_tokens_or_content.has_value())
throw std::runtime_error("--prompt_length, --prompt, and --prompt_file are mutually exclusive.");
prompt_num_tokens_or_content = std::string{next_arg(i)};
opts.prompt_specified = true;
} else if (arg == "--prompt_file") {
if (prompt_num_tokens_or_content.has_value())
throw std::runtime_error("--prompt_length, --prompt, and --prompt_file are mutually exclusive.");
prompt_num_tokens_or_content = ReadFileContent(next_arg(i));
opts.prompt_file_specified = true;
} else if (arg == "-g" || arg == "--generation_length") {
opts.num_tokens_to_generate = ParseNumber<size_t>(next_arg(i));
} else if (arg == "-r" || arg == "--repetitions") {
Expand All @@ -176,6 +166,15 @@ Options ParseOptionsFromCommandLine(int argc, const char* const* argv) {
opts.prompt_num_tokens_or_content = std::move(*prompt_num_tokens_or_content);
}

if (opts.use_random_tokens) {
if (!prompt_num_tokens_or_content.has_value() ||
!std::holds_alternative<size_t>(*prompt_num_tokens_or_content)) {
throw std::runtime_error(!prompt_num_tokens_or_content.has_value()
? "--use_random_tokens requires -l/--prompt_length."
: "--use_random_tokens cannot be used with --prompt or --prompt_file.");
}
}

VerifyOptions(opts);

return opts;
Expand Down
3 changes: 0 additions & 3 deletions benchmark/c/options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ struct Options {
size_t num_iterations{5};
size_t num_warmup_iterations{1};
int64_t max_length{0};
bool prompt_length_specified{};
bool prompt_specified{};
bool prompt_file_specified{};
bool verbose{};
bool reuse_generator{};
bool use_random_tokens{};
Expand Down
Loading