Update random token generation as suggested - #1
Merged
Conversation
Use the existing optional<PromptNumberOfTokensOrContent> as a sentinel to detect conflicts eagerly at parse time (throw immediately if a second prompt source is given). After the loop, the optional's own state is sufficient to validate --use_random_tokens: absent means -l was never given, string means --prompt/--prompt_file was given. This avoids adding fields to Options and keeps VerifyOptions' signature unchanged.
VishalX
merged commit May 21, 2026
a4bb5b2
into
vkjain/c-benchmark-random-tokens
1 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the existing optional as a sentinel to detect conflicts eagerly at parse time (throw immediately if a second prompt source is given). After the loop, the optional's own state is sufficient to validate --use_random_tokens: absent means -l was never given, string means --prompt/--prompt_file was given. This avoids adding fields to Options and keeps VerifyOptions' signature unchanged.