refactor!: declarative api #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
Apr 7, 2021
alardizabal
reviewed
Apr 7, 2021
felangel
reviewed
Apr 8, 2021
felangel
reviewed
Apr 8, 2021
felangel
reviewed
Apr 8, 2021
felangel
suggested changes
Apr 8, 2021
jeroen-meijer
force-pushed
the
refactor/declarative-api
branch
from
be24ca2 to
a2afe46
Compare
jeroen-meijer
force-pushed
the
refactor/declarative-api
branch
from
55eafb5 to
5d167c5
Compare
|
Do you need some support with finishing the PR? |
jdebecka
reviewed
Jul 20, 2021
jeroen-meijer
changed the title
|
@felangel As discussed offline, this refactor looks ready to get reviewed, merged and released! 😄 |
erickzanardo
previously approved these changes
Feb 9, 2022
example/pubspec.yaml
Outdated
| @@ -8,13 +8,16 @@ environment: | |||
| sdk: ">=2.12.0 <3.0.0" | |||
|
|
|||
| dependencies: | |||
| bloc: ^7.2.1 | |||
There was a problem hiding this comment.
Maybe we could update this to the latest bloc version?
lib/very_good_infinite_list.dart
Outdated
| this.loadingBuilder, | ||
| this.errorBuilder, | ||
| this.separatorBuilder, | ||
| required this.itemBuilder, |
There was a problem hiding this comment.
Nit: keep the required fields together after the Key for a better reading
lib/very_good_infinite_list.dart
Outdated
| _timer = Timer(_delay, action); | ||
| /// Calls the given [callback] after the given duration has passed. | ||
| @visibleForTesting | ||
| void call(void Function() callback) { |
There was a problem hiding this comment.
Suggested change
| void call(void Function() callback) { | |
| void call(VoidCallback callback) { |
Co-authored-by: Dominik Roszkowski <[email protected]>
based on feedback from @jdebecka
erickzanardo
force-pushed
the
refactor/declarative-api
branch
from
68fbb3a to
0c19b8c
Compare
felangel
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the API to use a more declarative approach, as described in #14.
It includes a version bump to
0.4.0.TODO
Type of Change