Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Toggle State Should Be Absolute. Toggle State Should Not Be A Suggestion Of An Action In Progress. #504

Open
Rock-N-Troll opened this issue Apr 13, 2019 · 8 comments
Labels
Bounty: Open This issue can be worked on by anyone that is interested in earning the bounty. Component: GUI Primarily related to the display of the user interface Dev Status: Help Wanted Seeking someone to help resolve this issue. Nobody is actively working on the issue. Issue Type: Feature Request Additional feature that would make Veil better. Tag: PoS Related to Proof of Stake

Comments

@Rock-N-Troll
Copy link

Rock-N-Troll commented Apr 13, 2019

Currently using a Toggle to perform an action in the GUI has a process go from State A to State B OR from State B back to State A.

However, the current visual toggle state appears to move to the next state before the next state is actually reached in the wallet's internals.
.
The wallet's state might be displayed as active/inactive when it actually is not what is displayed.

For this reason, there should be an intermediate state or pop-up that explains the user's action is being processed (Enabling...) (Disabling...) and the toggle should not move until the end state is actually reached by the wallet's internals.

Current Implemenation:

1.(May or May not actually be ENABLED)
image

  1. (May or May not actually be DISABLED)
    image

Possible/Proposed Implementation:

1.(Guaranteed to be ENABLED)
image

2a. Currently in the process of disabling and the GUI shows that the wallet is still precomputing
image

2b. Currently in the process of disabling and the GUI shows that the wallet is still precomputing
image

  1. (Guaranteed to be DISABLED)
    image

Whether or not this is the best way to show the user that their toggle click is being processed is not my place to decide. Maybe disabling the sliding indicator by greying it out will be a better way of showing an action is being performed and the toggle can't be clicked until the current toggle action is completed. Maybe a pop-up and graying out of the toggle switch is the best approach. It is a little tricky because normally toggle switches are immediate response, but if someone else has experience with best way to convey state to the user through toggles with long running processes then that can be an option as well.

However, the current user experience should be better in line with what was described at the start of this Feature Request: Toggle State should be absolutely correct. Users shouldn't be required to go to the console to determine the state of their wallet's staking/precomputing/etc.

@Rock-N-Troll Rock-N-Troll changed the title Feature Request: Toggle State Should Be Absolute. Toggle State Should Not Be A Suggesting An Action Is Being Done. Feature Request: Toggle State Should Be Absolute. Toggle State Should Not Be A Suggestion Of An Action Is Being Done. Apr 13, 2019
@Rock-N-Troll Rock-N-Troll changed the title Feature Request: Toggle State Should Be Absolute. Toggle State Should Not Be A Suggestion Of An Action Is Being Done. Feature Request: Toggle State Should Be Absolute. Toggle State Should Not Be A Suggestion Of An Action In Progress. Apr 13, 2019
@blondfrogs
Copy link
Collaborator

Right now the GUI does show the state of the actually staking and precomputing. When you click the precomputing slider, it will cause precomputing to be disabled within milliseconds. If it took minutes to disable or turn of precomputing or staking I could see a use case for having multiple pop ups showcasing the state of the current action, but because it is very quick I feel like the current design is giving the user valid information.

@Rock-N-Troll
Copy link
Author

Rock-N-Troll commented Apr 15, 2019

I should have created this post with the staking toggle as the center focus. The current issue is that it can take a couple of seconds for the process to end and in some cases is a runaway process (I think). Most application toggles are instant and therefore dont really need event listeners.

Users including myself aren't 100% certain the state of the staking toggle is 100% accurate either.

@Rock-N-Troll
Copy link
Author

Rock-N-Troll commented Apr 22, 2019

image

As shown in this image submitted by user Crypt0R1d3r in Discord, sometimes the state is inconsistent and makes it hard to determine which state is accurate.

@Rock-N-Troll
Copy link
Author

Rock-N-Troll commented Apr 24, 2019

image

As a good test case, If you restore a wallet from seed then the staking toggle is on by default but the getwalletinfo command clearly shows false.

@presstab
Copy link
Contributor

presstab commented May 2, 2019

The staking toggle switch is there to turn staking on or off. It is not there to give an indication of whether you are currently staking at that precise moment. The getwalletinfo command lags behind. Look at the logic there and it will be clear why.

@Rock-N-Troll
Copy link
Author

Users will continue to wonder if the wallet is actually working and if they are actually staking then

@veilgets veilgets added the Bounty: Open This issue can be worked on by anyone that is interested in earning the bounty. label Jun 20, 2019
@veilgets
Copy link

veilgets commented Jun 20, 2019

Bounty price: 375
Bounty updated

@codeofalltrades
Copy link
Collaborator

Related to #245

@codeofalltrades codeofalltrades added Tag: PoS Related to Proof of Stake Component: GUI Primarily related to the display of the user interface Issue Type: Feature Request Additional feature that would make Veil better. labels Oct 23, 2019
@codeofalltrades codeofalltrades added the Dev Status: Help Wanted Seeking someone to help resolve this issue. Nobody is actively working on the issue. label Dec 2, 2019
Repository owner deleted a comment from CaveSpectre11 Dec 4, 2019
CaveSpectre11 added a commit that referenced this issue Dec 19, 2020
cad2120 [GUI] Update Staking Slider to be reflective of status (Wet One)

Pull request description:

  ### Problem
  The staking slider does not always indicate the present state of staking.  There is a delay between when staking is enabled/disabled and when the actual enabling/disabling takes place.

  ### Root Cause
  The Qt indicates the state that the wallet is in.  Some amount of time is required to ensure that the state change has taken affect.  Additionally, staking is not performed while syncing.  When the user initially opens the user interface, staking is displayed as active while syncing.  Staking is initially active but will not be performed until syncing is complete.

  ### Solution
  * Text for the staking slider now shows the current state of actual staking (enabled, disable, disabled for sync, enabling ..., disabling...).
  * The staking slider is disabled (cannot be changed) until syncing is complete.
  * Once synchronization is complete, the staking slider will be changed to enabled with the state of "Enabling ...).  When finishing synchronization testing showed some thrashing between the states of "Enabling..." and "Staking Enabled" until a few blocks have gone by.  This is due to the way active staking is calculated.
  * RPC getwalletinfo updated to show the actual state of staking and the wallet status
  * Popup entering into staking disabled has been updated to indicate that some time is required prior to the state change taking effect.

  ### Issues Addressed
  245: #245
  504: #504

  ### Bounty Payment Address
  sv1qqphsvuwhk29xcn2q9gdth9x73qpm8kcktmuxyd8szl50sgt2nt47egpqwnxr83hfj7s6fnec2jr0cv5yc7r6s7nvxhd9969qrgy4cgnznwewqqqauut5m

Tree-SHA512: 73285595254c495afd804f422be993ba6f895643284210755a979535c8c0f0af31182b9bea0aa84705f69f15b2363ba7e14b6bcd7f454d300634483f24e3de65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Open This issue can be worked on by anyone that is interested in earning the bounty. Component: GUI Primarily related to the display of the user interface Dev Status: Help Wanted Seeking someone to help resolve this issue. Nobody is actively working on the issue. Issue Type: Feature Request Additional feature that would make Veil better. Tag: PoS Related to Proof of Stake
Projects
None yet
Development

No branches or pull requests

5 participants