Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide separate state labels when staking is enabled and disabled #245

Open
gabrielnergaard opened this issue Jan 9, 2019 · 0 comments
Open

Provide separate state labels when staking is enabled and disabled #245

gabrielnergaard opened this issue Jan 9, 2019 · 0 comments
Labels
Component: GUI Primarily related to the display of the user interface Issue Type: Feature Request Additional feature that would make Veil better. Issue Type: Missing Functionality Something is supposed to be in the application that is not.
Milestone
v1.2.0

Comments

@gabrielnergaard
Copy link
Contributor

I would like to show a different label when staking is enabled or disabled:

For example:

  • Staking is active
  • Staking disabled

Searching the codebase, however, it seems we currently don't support showing different labels depending on state. Could we please provide this?
@4x13 4x13 added Component: GUI Primarily related to the display of the user interface Issue Type: Missing Functionality Something is supposed to be in the application that is not. Issue Type: Feature Request Additional feature that would make Veil better. labels Jan 10, 2019
@4x13 4x13 added this to the v1.0.1 milestone Jan 10, 2019
@presstab presstab modified the milestones: v1.0.1, future Feb 21, 2019
@codeofalltrades codeofalltrades mentioned this issue Oct 23, 2019
Open
@CaveSpectre11 CaveSpectre11 modified the milestones: future, v1.2.0 Nov 23, 2020
@WetOne WetOne mentioned this issue Dec 6, 2020
Merged
CaveSpectre11 added a commit that referenced this issue Dec 19, 2020
@CaveSpectre11
Merge #880: [GUI] Update Staking Slider to be reflective of status
83bd2bf 
cad2120 [GUI] Update Staking Slider to be reflective of status (Wet One)

Pull request description:

  ### Problem
  The staking slider does not always indicate the present state of staking.  There is a delay between when staking is enabled/disabled and when the actual enabling/disabling takes place.

  ### Root Cause
  The Qt indicates the state that the wallet is in.  Some amount of time is required to ensure that the state change has taken affect.  Additionally, staking is not performed while syncing.  When the user initially opens the user interface, staking is displayed as active while syncing.  Staking is initially active but will not be performed until syncing is complete.

  ### Solution
  * Text for the staking slider now shows the current state of actual staking (enabled, disable, disabled for sync, enabling ..., disabling...).
  * The staking slider is disabled (cannot be changed) until syncing is complete.
  * Once synchronization is complete, the staking slider will be changed to enabled with the state of "Enabling ...).  When finishing synchronization testing showed some thrashing between the states of "Enabling..." and "Staking Enabled" until a few blocks have gone by.  This is due to the way active staking is calculated.
  * RPC getwalletinfo updated to show the actual state of staking and the wallet status
  * Popup entering into staking disabled has been updated to indicate that some time is required prior to the state change taking effect.

  ### Issues Addressed
  245: #245
  504: #504

  ### Bounty Payment Address
  sv1qqphsvuwhk29xcn2q9gdth9x73qpm8kcktmuxyd8szl50sgt2nt47egpqwnxr83hfj7s6fnec2jr0cv5yc7r6s7nvxhd9969qrgy4cgnznwewqqqauut5m

Tree-SHA512: 73285595254c495afd804f422be993ba6f895643284210755a979535c8c0f0af31182b9bea0aa84705f69f15b2363ba7e14b6bcd7f454d300634483f24e3de65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: GUI Primarily related to the display of the user interface Issue Type: Feature Request Additional feature that would make Veil better. Issue Type: Missing Functionality Something is supposed to be in the application that is not.
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
6 participants
@furszy @presstab @CaveSpectre11 @4x13 @veildev @gabrielnergaard