-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WARP: Update README with macOS library path instructions #6256
base: dev
Are you sure you want to change the base?
Conversation
62714ac
to
c5d3abc
Compare
c5d3abc
to
62878fb
Compare
Hi, thank you for the PR. I don't know why the README says to set Anyways what you want is to set Also this might interest you: Vector35/warp#22 (sigem docker image) |
@@ -18,10 +19,48 @@ fn compile_rust(file: PathBuf) -> bool { | |||
} | |||
|
|||
fn main() { | |||
if let Some(link_path) = option_env!("BINARYNINJADIR") { | |||
|
|||
let binja_base_dir: &str = option_env!("DEP_BINARYNINJACORE_BASE_DIR").unwrap_or_else(|| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our build system needs to set its own paths, so unfortunately we can't do lookups like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would work fine: 5239ad6
Lastrun is documented here for those curious: |
The README said to use
DEP_BINARYNINJACORE_PATH
but this was not referenced.I updated the
build.rs
to use this variable, and as a treat I added the default install locations from the User GuideI think this works on Windows too, but I do not have a Windows install to test. Thank you for the hard work on WARP I am excited to use it! 💜💜🥷