Link core in rust

When linking you must depend on the -sys crate
Vector35 · Sep 1, 2024 · ab06d72 · ab06d72
1 parent d565a12
commit ab06d72
Show file tree

Hide file tree

Showing 20 changed files with 114 additions and 514 deletions.
diff --git a/rust/binaryninjacore-sys/Cargo.toml b/rust/binaryninjacore-sys/Cargo.toml
@@ -1,8 +1,10 @@
 [package]
 name = "binaryninjacore-sys"
 version = "0.1.0"
+edition = "2021"
 authors = ["Ryan Snyder <[email protected]>", "Kyle Martin <[email protected]>"]
 build = "build.rs"
+links = "binaryninjacore"
 
 [build-dependencies]
 bindgen = "^0.69.2"
diff --git a/rust/binaryninjacore-sys/build.rs b/rust/binaryninjacore-sys/build.rs
@@ -74,8 +74,7 @@ fn main() {
         println!("cargo:rustc-link-search={}", out_dir);
     }
 
-    println!("cargo:rustc-link-lib=binaryninjacore");
-    println!("cargo:rustc-link-search={}", link_path.to_str().unwrap());
+    println!("cargo:path={}", link_path.to_str().unwrap());
 
     let current_line = "#define BN_CURRENT_UI_ABI_VERSION ";
     let minimum_line = "#define BN_MINIMUM_UI_ABI_VERSION ";

diff --git a/rust/build.rs b/rust/build.rs
@@ -9,4 +9,18 @@ fn main() {
         "target/doc/under_construction.png",
     );
     let _ = std::fs::copy("../docs/img/logo.png", "target/doc/logo.png");
+
+    let link_path =
+        std::env::var_os("DEP_BINARYNINJACORE_PATH").expect("DEP_BINARYNINJACORE_PATH specified");
+
+    println!("cargo::rustc-link-lib=dylib=binaryninjacore");
+    println!("cargo::rustc-link-search={}", link_path.to_str().unwrap());
+
+    #[cfg(not(target_os = "windows"))]
+    {
+        println!(
+            "cargo::rustc-link-arg=-Wl,-rpath,{0},-L{0}",
+            link_path.to_string_lossy()
+        );
+    }
 }
diff --git a/rust/examples/basic_script/Cargo.toml b/rust/examples/basic_script/Cargo.toml
@@ -6,3 +6,4 @@ edition = "2021"
 
 [dependencies]
 binaryninja = {path="../../"}
+binaryninjacore-sys = {path="../../binaryninjacore-sys"}
diff --git a/rust/examples/basic_script/build.rs b/rust/examples/basic_script/build.rs
@@ -1,68 +1,15 @@
-use std::env;
-use std::fs::File;
-use std::io::BufReader;
-use std::path::PathBuf;
-
-#[cfg(target_os = "macos")]
-static LASTRUN_PATH: (&str, &str) = ("HOME", "Library/Application Support/Binary Ninja/lastrun");
-
-#[cfg(target_os = "linux")]
-static LASTRUN_PATH: (&str, &str) = ("HOME", ".binaryninja/lastrun");
-
-#[cfg(windows)]
-static LASTRUN_PATH: (&str, &str) = ("APPDATA", "Binary Ninja\\lastrun");
-
-// Check last run location for path to BinaryNinja; Otherwise check the default install locations
-fn link_path() -> PathBuf {
-    use std::io::prelude::*;
-
-    let home = PathBuf::from(env::var(LASTRUN_PATH.0).unwrap());
-    let lastrun = PathBuf::from(&home).join(LASTRUN_PATH.1);
-
-    File::open(lastrun)
-        .and_then(|f| {
-            let mut binja_path = String::new();
-            let mut reader = BufReader::new(f);
-
-            reader.read_line(&mut binja_path)?;
-            Ok(PathBuf::from(binja_path.trim()))
-        })
-        .unwrap_or_else(|_| {
-            #[cfg(target_os = "macos")]
-            return PathBuf::from("/Applications/Binary Ninja.app/Contents/MacOS");
-
-            #[cfg(target_os = "linux")]
-            return home.join("binaryninja");
-
-            #[cfg(windows)]
-            return PathBuf::from(env::var("PROGRAMFILES").unwrap())
-                .join("Vector35\\BinaryNinja\\");
-        })
-}
-
 fn main() {
-    // Use BINARYNINJADIR first for custom BN builds/configurations (BN devs/build server), fallback on defaults
-    let install_path = env::var("BINARYNINJADIR")
-        .map(PathBuf::from)
-        .unwrap_or_else(|_| link_path());
-
-    #[cfg(target_os = "linux")]
-    println!(
-        "cargo:rustc-link-arg=-Wl,-rpath,{},-L{},-l:libbinaryninjacore.so.1",
-        install_path.to_str().unwrap(),
-        install_path.to_str().unwrap(),
-    );
-
-    #[cfg(target_os = "macos")]
-    println!(
-        "cargo:rustc-link-arg=-Wl,-rpath,{},-L{},-lbinaryninjacore",
-        install_path.to_str().unwrap(),
-        install_path.to_str().unwrap(),
-    );
-
-    #[cfg(target_os = "windows")]
+    let link_path =
+        std::env::var_os("DEP_BINARYNINJACORE_PATH").expect("DEP_BINARYNINJACORE_PATH specified");
+
+    println!("cargo::rustc-link-lib=dylib=binaryninjacore");
+    println!("cargo::rustc-link-search={}", link_path.to_str().unwrap());
+
+    #[cfg(not(target_os = "windows"))]
     {
-        println!("cargo:rustc-link-lib=binaryninjacore");
-        println!("cargo:rustc-link-search={}", install_path.to_str().unwrap());
+        println!(
+            "cargo::rustc-link-arg=-Wl,-rpath,{0},-L{0}",
+            link_path.to_string_lossy()
+        );
     }
 }
diff --git a/rust/examples/decompile/Cargo.toml b/rust/examples/decompile/Cargo.toml
@@ -6,5 +6,6 @@ edition = "2021"
 
 [dependencies]
 binaryninja = {path="../../"}
+binaryninjacore-sys = {path="../../binaryninjacore-sys"}
 clap = { version = "4.4", features = ["derive"] }
 
diff --git a/rust/examples/decompile/build.rs b/rust/examples/decompile/build.rs
@@ -1,68 +1,15 @@
-use std::env;
-use std::fs::File;
-use std::io::BufReader;
-use std::path::PathBuf;
-
-#[cfg(target_os = "macos")]
-static LASTRUN_PATH: (&str, &str) = ("HOME", "Library/Application Support/Binary Ninja/lastrun");
-
-#[cfg(target_os = "linux")]
-static LASTRUN_PATH: (&str, &str) = ("HOME", ".binaryninja/lastrun");
-
-#[cfg(windows)]
-static LASTRUN_PATH: (&str, &str) = ("APPDATA", "Binary Ninja\\lastrun");
-
-// Check last run location for path to BinaryNinja; Otherwise check the default install locations
-fn link_path() -> PathBuf {
-    use std::io::prelude::*;
-
-    let home = PathBuf::from(env::var(LASTRUN_PATH.0).unwrap());
-    let lastrun = PathBuf::from(&home).join(LASTRUN_PATH.1);
-
-    File::open(lastrun)
-        .and_then(|f| {
-            let mut binja_path = String::new();
-            let mut reader = BufReader::new(f);
-
-            reader.read_line(&mut binja_path)?;
-            Ok(PathBuf::from(binja_path.trim()))
-        })
-        .unwrap_or_else(|_| {
-            #[cfg(target_os = "macos")]
-            return PathBuf::from("/Applications/Binary Ninja.app/Contents/MacOS");
-
-            #[cfg(target_os = "linux")]
-            return home.join("binaryninja");
-
-            #[cfg(windows)]
-            return PathBuf::from(env::var("PROGRAMFILES").unwrap())
-                .join("Vector35\\BinaryNinja\\");
-        })
-}
-
 fn main() {
-    // Use BINARYNINJADIR first for custom BN builds/configurations (BN devs/build server), fallback on defaults
-    let install_path = env::var("BINARYNINJADIR")
-        .map(PathBuf::from)
-        .unwrap_or_else(|_| link_path());
-
-    #[cfg(target_os = "linux")]
-    println!(
-        "cargo:rustc-link-arg=-Wl,-rpath,{},-L{},-l:libbinaryninjacore.so.1",
-        install_path.to_str().unwrap(),
-        install_path.to_str().unwrap(),
-    );
-
-    #[cfg(target_os = "macos")]
-    println!(
-        "cargo:rustc-link-arg=-Wl,-rpath,{},-L{},-lbinaryninjacore",
-        install_path.to_str().unwrap(),
-        install_path.to_str().unwrap(),
-    );
-
-    #[cfg(target_os = "windows")]
+    let link_path =
+        std::env::var_os("DEP_BINARYNINJACORE_PATH").expect("DEP_BINARYNINJACORE_PATH specified");
+
+    println!("cargo::rustc-link-lib=dylib=binaryninjacore");
+    println!("cargo::rustc-link-search={}", link_path.to_str().unwrap());
+
+    #[cfg(not(target_os = "windows"))]
     {
-        println!("cargo:rustc-link-lib=binaryninjacore");
-        println!("cargo:rustc-link-search={}", install_path.to_str().unwrap());
+        println!(
+            "cargo::rustc-link-arg=-Wl,-rpath,{0},-L{0}",
+            link_path.to_string_lossy()
+        );
     }
 }
diff --git a/rust/examples/dwarf/dwarf_export/Cargo.toml b/rust/examples/dwarf/dwarf_export/Cargo.toml
@@ -8,6 +8,7 @@ crate-type = ["cdylib"]
 
 [dependencies]
 binaryninja = {path="../../../"}
+binaryninjacore-sys = {path="../../../binaryninjacore-sys"}
 gimli = "^0.31"
 log = "^0.4"
 object = { version = "0.32.1", features = ["write"] }
diff --git a/rust/examples/dwarf/dwarf_export/build.rs b/rust/examples/dwarf/dwarf_export/build.rs
@@ -1,68 +1,15 @@
-use std::env;
-use std::fs::File;
-use std::io::BufReader;
-use std::path::PathBuf;
-
-#[cfg(target_os = "macos")]
-static LASTRUN_PATH: (&str, &str) = ("HOME", "Library/Application Support/Binary Ninja/lastrun");
-
-#[cfg(target_os = "linux")]
-static LASTRUN_PATH: (&str, &str) = ("HOME", ".binaryninja/lastrun");
-
-#[cfg(windows)]
-static LASTRUN_PATH: (&str, &str) = ("APPDATA", "Binary Ninja\\lastrun");
-
-// Check last run location for path to BinaryNinja; Otherwise check the default install locations
-fn link_path() -> PathBuf {
-    use std::io::prelude::*;
-
-    let home = PathBuf::from(env::var(LASTRUN_PATH.0).unwrap());
-    let lastrun = PathBuf::from(&home).join(LASTRUN_PATH.1);
-
-    File::open(lastrun)
-        .and_then(|f| {
-            let mut binja_path = String::new();
-            let mut reader = BufReader::new(f);
-
-            reader.read_line(&mut binja_path)?;
-            Ok(PathBuf::from(binja_path.trim()))
-        })
-        .unwrap_or_else(|_| {
-            #[cfg(target_os = "macos")]
-            return PathBuf::from("/Applications/Binary Ninja.app/Contents/MacOS");
-
-            #[cfg(target_os = "linux")]
-            return home.join("binaryninja");
-
-            #[cfg(windows)]
-            return PathBuf::from(env::var("PROGRAMFILES").unwrap())
-                .join("Vector35\\BinaryNinja\\");
-        })
-}
-
 fn main() {
-    // Use BINARYNINJADIR first for custom BN builds/configurations (BN devs/build server), fallback on defaults
-    let install_path = env::var("BINARYNINJADIR")
-        .map(PathBuf::from)
-        .unwrap_or_else(|_| link_path());
-
-    #[cfg(target_os = "linux")]
-    println!(
-        "cargo:rustc-link-arg=-Wl,-rpath,{},-L{},-l:libbinaryninjacore.so.1",
-        install_path.to_str().unwrap(),
-        install_path.to_str().unwrap(),
-    );
-
-    #[cfg(target_os = "macos")]
-    println!(
-        "cargo:rustc-link-arg=-Wl,-rpath,{},-L{},-lbinaryninjacore",
-        install_path.to_str().unwrap(),
-        install_path.to_str().unwrap(),
-    );
-
-    #[cfg(target_os = "windows")]
-    {
-        println!("cargo:rustc-link-lib=binaryninjacore");
-        println!("cargo:rustc-link-search={}", install_path.to_str().unwrap());
-    }
+    // let link_path =
+    //     std::env::var_os("DEP_BINARYNINJACORE_PATH").expect("DEP_BINARYNINJACORE_PATH specified");
+    // 
+    // println!("cargo::rustc-link-lib=dylib=binaryninjacore");
+    // println!("cargo::rustc-link-search={}", link_path.to_str().unwrap());
+    // 
+    // #[cfg(not(target_os = "windows"))]
+    // {
+    //     println!(
+    //         "cargo::rustc-link-arg=-Wl,-rpath,{0},-L{0}",
+    //         link_path.to_string_lossy()
+    //     );
+    // }
 }
diff --git a/rust/examples/flowgraph/Cargo.toml b/rust/examples/flowgraph/Cargo.toml
@@ -9,3 +9,4 @@ crate-type = ["cdylib"]
 
 [dependencies]
 binaryninja = {path="../../"}
+binaryninjacore-sys = {path="../../binaryninjacore-sys"}
diff --git a/rust/examples/hlil_lifter/Cargo.toml b/rust/examples/hlil_lifter/Cargo.toml
@@ -10,6 +10,7 @@ edition = "2021"
 # You can point at the BinaryNinja dependency in one of two ways, via path:
 [dependencies]
 binaryninja = {path="../../"}
+binaryninjacore-sys = {path="../../binaryninjacore-sys"}
 
 # Or directly at the git repo:
 # [dependencies]

diff --git a/rust/examples/hlil_lifter/build.rs b/rust/examples/hlil_lifter/build.rs
@@ -1,68 +1,15 @@
-use std::env;
-use std::fs::File;
-use std::io::BufReader;
-use std::path::PathBuf;
-
-#[cfg(target_os = "macos")]
-static LASTRUN_PATH: (&str, &str) = ("HOME", "Library/Application Support/Binary Ninja/lastrun");
-
-#[cfg(target_os = "linux")]
-static LASTRUN_PATH: (&str, &str) = ("HOME", ".binaryninja/lastrun");
-
-#[cfg(windows)]
-static LASTRUN_PATH: (&str, &str) = ("APPDATA", "Binary Ninja\\lastrun");
-
-// Check last run location for path to BinaryNinja; Otherwise check the default install locations
-fn link_path() -> PathBuf {
-    use std::io::prelude::*;
-
-    let home = PathBuf::from(env::var(LASTRUN_PATH.0).unwrap());
-    let lastrun = PathBuf::from(&home).join(LASTRUN_PATH.1);
-
-    File::open(lastrun)
-        .and_then(|f| {
-            let mut binja_path = String::new();
-            let mut reader = BufReader::new(f);
-
-            reader.read_line(&mut binja_path)?;
-            Ok(PathBuf::from(binja_path.trim()))
-        })
-        .unwrap_or_else(|_| {
-            #[cfg(target_os = "macos")]
-            return PathBuf::from("/Applications/Binary Ninja.app/Contents/MacOS");
-
-            #[cfg(target_os = "linux")]
-            return home.join("binaryninja");
-
-            #[cfg(windows)]
-            return PathBuf::from(env::var("PROGRAMFILES").unwrap())
-                .join("Vector35\\BinaryNinja\\");
-        })
-}
-
 fn main() {
-    // Use BINARYNINJADIR first for custom BN builds/configurations (BN devs/build server), fallback on defaults
-    let install_path = env::var("BINARYNINJADIR")
-        .map(PathBuf::from)
-        .unwrap_or_else(|_| link_path());
-
-    #[cfg(target_os = "linux")]
-    println!(
-        "cargo:rustc-link-arg=-Wl,-rpath,{},-L{},-l:libbinaryninjacore.so.1",
-        install_path.to_str().unwrap(),
-        install_path.to_str().unwrap(),
-    );
+    let link_path =
+        std::env::var_os("DEP_BINARYNINJACORE_PATH").expect("DEP_BINARYNINJACORE_PATH specified");
 
-    #[cfg(target_os = "macos")]
-    println!(
-        "cargo:rustc-link-arg=-Wl,-rpath,{},-L{},-lbinaryninjacore",
-        install_path.to_str().unwrap(),
-        install_path.to_str().unwrap(),
-    );
+    println!("cargo::rustc-link-lib=dylib=binaryninjacore");
+    println!("cargo::rustc-link-search={}", link_path.to_str().unwrap());
 
-    #[cfg(target_os = "windows")]
+    #[cfg(not(target_os = "windows"))]
     {
-        println!("cargo:rustc-link-lib=binaryninjacore");
-        println!("cargo:rustc-link-search={}", install_path.to_str().unwrap());
+        println!(
+            "cargo::rustc-link-arg=-Wl,-rpath,{0},-L{0}",
+            link_path.to_string_lossy()
+        );
     }
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,3 +6,4 @@ edition = "2021"

		[dependencies]
		binaryninja = {path="../../"}
		binaryninjacore-sys = {path="../../binaryninjacore-sys"}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -9,3 +9,4 @@ crate-type = ["cdylib"]

		[dependencies]
		binaryninja = {path="../../"}
		binaryninjacore-sys = {path="../../binaryninjacore-sys"}