Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use script to generate icons #618

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Conversation

daiyam
Copy link
Member

@daiyam daiyam commented Jan 18, 2021

This PR adds a script to generate the icons.

It should fix #614 and it can easily updated for #616.

@stripedpajamas
Copy link
Member

thanks for putting this together @daiyam. what's the intended use? like do we run once whenever the icon changes and commit the resulting icon sets? or do we run the script at build time?

@setanarut
Copy link
Contributor

thanks for putting this together @daiyam. what's the intended use? like do we run once whenever the icon changes and commit the resulting icon sets? or do we run the script at build time?

run once. this should only be produced once until the next icon change.

@stripedpajamas
Copy link
Member

dope. is it merge-ready ? (not sure if it was updated regarding discussion #616 )

@daiyam
Copy link
Member Author

daiyam commented Jan 19, 2021

Yes, now, it's using the icon from #616.

@stripedpajamas
Copy link
Member

Thanks @daiyam and @hazarek

@stripedpajamas stripedpajamas merged commit 6dd97cc into VSCodium:master Jan 19, 2021
@daiyam daiyam deleted the update-icons branch January 19, 2021 23:13
@setanarut setanarut mentioned this pull request Feb 7, 2021
2 tasks
@sefsh
Copy link

sefsh commented Feb 9, 2021

Please reopen and do it right, #616 doesn't adhere to macOS standards.

@setanarut
Copy link
Contributor

Please reopen and do it right, #616 doesn't adhere to macOS standards.

#616 (reply in thread)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Golang icon (go.icns)
4 participants