[WIP] Fix whitespace/tab j/k issues

[johnfn]

This is an implementation that sort of works but is annoying.

Does anyone know a better way to do this?

• @rebornix, others - tabstop does not always report the correct width of a tab - it seems like the setting can be overridden in-editor somehow. Do you know how to get the right width?
• anyone (but maybe @rebornix knows..?) - is there some provided way to move up/down through a document that has spaces and tabs while keeping the cursor on the right column?

[xconverge]

@johnfn I have some stuff stashed from yesterday that is done EXACTLY the same way as this but I didnt get to finish the implementation for up, I only did down and came to similar conclusions that it felt crazy...

What you are looking for is

vscode.window.activeTextEditor.options.tabSize;

I added a getTabSize() to TextEditor that returned this

[johnfn]

Aww haha man sorry @xconverge! Good find on the tabSize thing though. Perhaps we should use that in Configuration.

You can always let me know on slack or whatever if you're working on a bigger feature. Also don't be afraid of opening WIP PRs earlier rather than later. :)

[rebornix]

@johnfn I missed this PR for a long time. Yes @xconverge is right, that reading config from activeTextEditor.options is always correct. About moving cursor up and down without calculating desired column ourselves is command cursorMove, you have seen that quite a few times when I implemented those scrolling features.

[xconverge]

@johnfn @rebornix Is this fixed somehow (assuming vscode reports different character values now?) assuming #842 is now closed?

[johnfn]

How could this be fixed?? o_O

[xconverge]

My thought is that vscode may report a tab char as more than 1?

[johnfn]

That would be weird because then what would it mean to insert at character 1 on a line filled with tabs?

meh, if it works it works :P

[jpoon]

Spring cleaning. Closing this PR as there hasn't been movement in awhile. Feel free to re-open.