Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

j/k moving diagonally #842

Closed
octref opened this issue Oct 5, 2016 · 11 comments
Closed

j/k moving diagonally #842

octref opened this issue Oct 5, 2016 · 11 comments
Labels

Comments

@octref
Copy link
Contributor

octref commented Oct 5, 2016

As you see it's moving diagonally.

j

Technical details:

  • VSCode Version: 1.6 Insiders
  • VsCodeVim Version: 0.3
  • OS: OS X 10.11.6
@xconverge
Copy link
Member

I cant reproduce this, does it happen all of the time for you?

@octref
Copy link
Contributor Author

octref commented Oct 5, 2016

Seems to happen if I'm moving from outside of a {} to inside.

jk

@johnfn
Copy link
Member

johnfn commented Oct 5, 2016

I can't reproduce this either. Do you have any other extensions running? Also, what language is that? (It looks like TypeScript?)

@octref
Copy link
Contributor Author

octref commented Oct 5, 2016

@johnfn @xconverge

Figured out the problem. This happens when indentation is tab.

@octref
Copy link
Contributor Author

octref commented Oct 5, 2016

Now it makes sense. The fix would be make a tab tabSize long instead of 1 char long when calculating movement.

@xconverge
Copy link
Member

@octref right on! Reproduced the issue, thanks for finding it

@rebornix
Copy link
Member

@octref good catch.

We need take tabStop into consideration while calculating desiredColumn.

@xconverge
Copy link
Member

@johnfn is working on this in #859

@octref
Copy link
Contributor Author

octref commented Nov 17, 2016

@xconverge This seems to be fixed so closing it.

@johnfn
Copy link
Member

johnfn commented Nov 30, 2016

This was not fixed. It still appears to be a problem in master.

@jpoon
Copy link
Member

jpoon commented May 6, 2019

Given the old age of this bug, the lack of activity, and that I can't repro, closing as this bug has likely been fixed on the latest release.

@jpoon jpoon closed this as completed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants